New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database/sql: TestStmtCloseDeps failure on windows-amd64-longtest #49958
Comments
Thanks. I'll try to duplicate ASAP and diagnose. I agree that fundamental changes were recently made. |
@bcmills I was unable to reproduce locally to date. When looking at the test itself, it contains a I could (a) ignore this, or (b) try to modify the test to not include this sleep. |
Given that users' development configurations and CI systems are likely even more variable than the Go project's builders, it seems like a good idea to modify the test to avoid arbitrary sleeps. |
database/sql tests are moving that direction; I'll see what I can do to remove the dependency on sleeps. |
2022-01-11T21:51:51-ad7eae2/windows-amd64-longtest This is looking like a regression in Go 1.18 — possibly related to the runtime's pacing changes? (CC @mknyszek) |
Change https://golang.org/cl/378395 mentions this issue: |
Also eliminate some arbitrary deadlines and sleeps. Fixes golang#49958 Change-Id: I999b39a896e430e3bb93aa8b8c9444f28bbaa9d0 Reviewed-on: https://go-review.googlesource.com/c/go/+/378395 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Daniel Theophanes <kardianos@gmail.com>
greplogs --dashboard -md -l -e 'FAIL: TestStmtCloseDeps ' --since=2020-01-01
2021-11-27T19:49:32-a142d65/windows-amd64-longtest
This is the regression test for #5323. Only one failure has been seen in the logs, but since the test is skipped it short mode the sample size is relatively smaller than for most tests; however, there have been fairly recent changes in
database/sql
(CC @kardianos, @ianlancetaylor).The text was updated successfully, but these errors were encountered: