Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codereview.py throws an exception trying to parse an incorrect change list [patch] #525

Closed
gopherbot opened this issue Jan 13, 2010 · 2 comments
Closed

codereview.py throws an exception trying to parse an incorrect change list [patch] #525

gopherbot opened this issue Jan 13, 2010 · 2 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link
Contributor

by waikurosu:

What steps will reproduce the problem?
1. Run hg change
2. Make a mistake/type in crap
3. Save

What is the expected output? What do you see instead?
It should prompt you to re-edit, instead there are explosions.

What is your $GOOS?  $GOARCH?
linux/x86

Which revision are you using?  (hg identify)
d9b2e68a1bd2+ tip

Please provide any additional information below.
I have attached a patch to fix this bug (and I've tested it).
I followed the API docs at http://mercurial.selenic.com/wiki/MercurialApi

Attachments:

  1. codereview.py-prompt-on-error-fix.patch (931 bytes)
@rsc
Copy link
Contributor

rsc commented Jan 19, 2010

Comment 1:

Sigh.  What a crock.  The real fix has to try both 
because this changed only recently (between 1.3 and 1.3.1,
and somehow my Mercurial prints 1.3.1 but has the old version).
I've made the change and will submit it shortly.
Thanks for the report.

Owner changed to r...@golang.org.

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Jan 20, 2010

Comment 2:

This issue was closed by revision ff7343f.

Status changed to Fixed.

Merged into issue #-.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsc @gopherbot