-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
time.ISO8601 versus ISO 8601, W3C, RFC 3339, and RFC 822 #734
Labels
Comments
Owner changed to r...@golang.org. Status changed to Accepted. |
What a mess. It would be nice to have a solution that didn't involve making up new strings but I don't see a good one. I'll never remember which one is ZB and which is ZX. Maybe the formats should be "Z0700" and "Z07:00"? I don't think there's a need for OldISO8601. The code I've written using ISO8601 was really trying to be RFC3339 and only ever dealt with UTC times. ISO8601 = "..." // ISO 8601 basic format RFC3339 = "..." // RFC 3339 |
Z0700 and Z07:00 are a definite improvement. Your comment about OldISO8601 makes me wonder if ISO8601 should be dropped as well. It suggests that time.Parse(time.ISO8601, value) will understand any ISO 8601 date, which just isn't true. Also, removing it means that code that depended on it will fail to compile, preventing any sort of accidental breakage from the format change. I've made these changes to my local copy. I'll submit a CL for review tomorrow, if you'd like. |
This issue was closed by revision 6c124cb. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by micah.stetson:
The text was updated successfully, but these errors were encountered: