netchan: closing a channel on exported end doesn't propagate to the caller #805
Labels
Comments
|
Owner changed to r...@golang.org. Status changed to Accepted. |
|
This issue was closed by revision 752b47c. Status changed to Fixed. |
As mentioned on issue #790, I believe that closing the channel should also flush the buffer prior to returning. |
That's not the way closed works even on local channels. http://golang.org/doc/go_spec.html#Close_and_closed Only the *receiver* should be checking closed. Status changed to Invalid. |
|
Issue #1116 has been merged into this issue. |
I'm checking for closed on the receiver side. When the sender process exits the receiver gives me "error decoding client header: EOF" even though closed() returns false. I've attached EchoClient and EchoServer. The server gives me the error. Attachments:
|
Sorry, posting to golang-nuts is a little tricky as I am in China behind the GFC and google groups is blocked. I've got a workaround, but it is s...l...o...w. I'm digging into this from the bottom up now. The Go distro has test netchan_test.go. Running as separate processes I get the behaviour documented in issue #790 of last message not being sent and receiver hanging as it doesn't see the close from the sender. This can be fixed by the exporter (sender) calling Drain, but then the reader sees the closing 0 (for ints) or "" (for strings) (couldn't find the bug report I saw for this). If the sender closes without Drain, then the reader doesn't see closed. Importer doesn't have a Drain method so can't successfully signal closure to a reader. This requires separate processes to demonstrate, not goroutines. So... Importer needs a Drain method at least. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by ghexsel:
I have a loop in the exporter sender side that sends 10 items then closes the netchan. On the importer side, I have a loop to check if the channel is closed before trying to receive, but the channel doesn't appear to get closed. Instead, I see the "2010/05/23 16:39:38 importer header: EOF" message (in the importer receiver side). A simple solution would be to change the sender side to consider EOF a close signal on importer.go#run(). Exporter relevant bits: for i := 0; i < count; i++ { if closed(ch) { fmt.Printf("Can't send, channel is closed\n") os.Exit(1) } else { ch <- value {23 + i, "hello"} } } close(ch) Importer relevant bits: for { if closed(ch) { fmt.Printf("Can't receive, channel is closed\n") os.Exit(0) } else { v := <-ch fmt.Printf("%v\n", v) } }The text was updated successfully, but these errors were encountered: