http.Request.Write ignores Proto{Major,Minor} #910
Labels
Comments
It's a bit more complicated than just changing the HTTP/1.1 to HTTP/%d.%d though, as the go http package only supports chunked encoding. It has no support for slurping up bodies ahead of time to measure their length and add HTTP/1.0 Content-Length headers. That'd likely be a lot of work. The easier fix might just be a documentation clarification that requests are always HTTP/1.1. |
|
Owner changed to a...@golang.org. Status changed to Accepted. |
|
Labels changed: added pkg-http. Owner changed to @bradfitz. |
Now that it's possible to send un-chunked requests (by setting Request.ContentLength > 0), I'm closing this with just a documentation update: http://golang.org/cl/4439062 |
|
This issue was closed by revision 8d6a12f. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by temotor:
What steps will reproduce the problem? req := new(http.Request) req.URL = http.ParseURL("http://localhost/";) req.ProtoMajor, req.ProtoMinor = 1, 0 // debug dump, _ := http.DumpRequest(req, true) print(string(dump)) What is the expected output? GET / HTTP/1.0 ... What do you see instead? GET / HTTP/1.1 ... What is your $GOOS? $GOARCH? linux amd64 Which revision are you using? (hg identify) 5af6f6656531 tip Please provide any additional information below. The problem is clearly in src/pkg/http/request.go here's code: fmt.Fprintf(w, "%s %s HTTP/1.1\r\n", valueOrDefault(req.Method, "GET"), uri) and although function comment explicitly states that request will be HTTP/1.1: // Write writes an HTTP/1.1 request -- header and body -- in wire format. i reckon that all request fields should be respected, including Proto*.The text was updated successfully, but these errors were encountered: