http: make http client request with context #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ctx naming convention - use context.TODO() instead of nil Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
desimone
changed the title
|
Sorry, NewRequestWithContext is too new (Go 1.13) to start using already. Use Request.WithContext instead for now. |
Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
TIL!
Done! |
5 tasks
desimone
changed the title
scbizu
added a commit
to ezbuy/groupcache
that referenced
this pull request
Sep 11, 2020
This reverts commit 8c9f03a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http: use NewRequestWithContext to support cancellation
Sorry, missed a few of these in my first go.