Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Parse parenthesized parameter-type. #421

Merged

Conversation

Krout0n
Copy link
Contributor

@Krout0n Krout0n commented Mar 27, 2020

Fixes #416.

Description
Add a case for parsing *ast.ParenExpr in fileParser#parseType.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Krout0n Krout0n force-pushed the fix-parsing-parenthesized-parameter-type branch 3 times, most recently from e1337b7 to b920dc7 Compare March 27, 2020 09:44
@Krout0n
Copy link
Contributor Author

Krout0n commented Mar 27, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Krout0n Krout0n changed the title Accept parenthesized parameter-type. Parse parenthesized parameter-type. Mar 27, 2020
@codyoss
Copy link
Member

codyoss commented Mar 28, 2020

Can you please format this PR. That is what is failing in the CI.

@Krout0n Krout0n force-pushed the fix-parsing-parenthesized-parameter-type branch from b920dc7 to 84b5306 Compare March 30, 2020 12:59
@Krout0n
Copy link
Contributor Author

Krout0n commented Mar 30, 2020

ParenthesizedParameterType(param (int))

Ah, in this case, the code formatting is required... okay, I fixed the test case.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit d476d65 into golang:master Mar 30, 2020
@codyoss
Copy link
Member

codyoss commented Mar 30, 2020

Thanks for your contribution 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed parsing when the parameter type is parenthesized.
3 participants