Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix docs for AssignableToTypeOf #452

Merged
merged 1 commit into from Jul 10, 2020
Merged

fix docs for AssignableToTypeOf #452

merged 1 commit into from Jul 10, 2020

Conversation

ethervoid
Copy link
Contributor

@ethervoid ethervoid commented Jun 26, 2020

To make the example work we need to include the element to be casted

Fixes #453. in case of a bug fix, this should point to a bug and any other related issue(s)

Description

The example included in the documentation doesn't work. This PR fixes the documentation
to help other people that want to use it to learn how AssignableToTypeOf can be used.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

To make the example work we need to include the element to be casted
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ethervoid
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document line for AssignableToTypeOf is wrong
3 participants