Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Fix: missing ignore Fatal in SetArg function #594

Merged
merged 4 commits into from Dec 30, 2021
Merged

Fix: missing ignore Fatal in SetArg function #594

merged 4 commits into from Dec 30, 2021

Conversation

lovung
Copy link
Contributor

@lovung lovung commented Oct 4, 2021

In my #589, I missed to add the skip line in switch case.

@lovung lovung requested a review from codyoss as a code owner October 4, 2021 08:04
@lovung
Copy link
Contributor Author

lovung commented Oct 7, 2021

@codyoss Please help to review this PR when you have time. Thanks.

@lovung
Copy link
Contributor Author

lovung commented Oct 22, 2021

@codyoss Hello, could you help to review this PR?

gomock/call.go Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Oct 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lovung
Copy link
Contributor Author

lovung commented Oct 30, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Oct 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lovung lovung requested a review from codyoss October 30, 2021 05:31
@lovung
Copy link
Contributor Author

lovung commented Nov 7, 2021

@codyoss Hello, could you help to review this PR?

@lovung
Copy link
Contributor Author

lovung commented Nov 25, 2021

@codyoss ping

@lovung
Copy link
Contributor Author

lovung commented Dec 16, 2021

@codyoss Could you help to review my MR again?

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for not getting back to you sooner!

@codyoss codyoss merged commit bdab070 into golang:master Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants