Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Make import alias generation predictable #66

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Conversation

rmohr
Copy link
Contributor

@rmohr rmohr commented Mar 13, 2017

Instead of iterating over a set and generating aliases for conflicting
immports, iterate over a sorted map based on this set. This ensured
predictable output and makes automated checks possible.

We for instance had the problem that our automated check if go generate was run, sometimes fails because of different generated code by gomock.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Instead of iterating over a set and generating aliases for conflicting
immports, iterate over a sorted map based on this set. This ensured
predictable output and makes automated checks possible.
@rmohr
Copy link
Contributor Author

rmohr commented Mar 13, 2017

I signed it!

@fabiand
Copy link

fabiand commented Mar 13, 2017

@googlebot @rmohr is covered under the Red Hat CLA.

@eparis
Copy link

eparis commented Jun 16, 2017

@googlebot he signed it!

@googlebot
Copy link

CLAs look good, thanks!

@balshetzer balshetzer merged commit e9b646f into golang:master Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants