Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it would be good to clearly indicate that this repo does not use pull requests #217

Closed
neelance opened this issue Feb 11, 2017 · 7 comments

Comments

@neelance
Copy link
Member

Imho it is not very obvious that this project does not use pull requests. It is probably not only me, because the main Go repo has 58 closed pull requests whereas this repo has 65. Wanting to contribute and then having the PR being closed by the bot is a frustrating experience. There is the CONTRIBUTING.md file, but I suggest adding two measures that the main Go repo uses:

  1. Adding a section to the readme similar to the "Contributing" section of https://github.com/golang/go/#contributing, which states that pull requests are not used.
  2. Open a dummy pull request similar to the one on https://github.com/golang/go/pulls.
@rakyll
Copy link
Contributor

rakyll commented Feb 13, 2017

@bradfitz, how do we open a PR and make sure it is not auto-closed by the bot similar to golang/go#9220?

@bradfitz
Copy link
Contributor

I'm confused. Do you mean you want it to be auto-closed or not? It's already not, no?

@rakyll
Copy link
Contributor

rakyll commented Feb 13, 2017

I want to open a PR against this repo as a reminder that we don't accept PRs (similar to golang/go#9220). I don't want it to be auto closed by the bot. How do I do that?

@rakyll
Copy link
Contributor

rakyll commented Feb 13, 2017

@bradfitz
Copy link
Contributor

Modify x/build/cmd/pushback perhaps? Or just let it be auto-closed and then re-open it?

@rakyll
Copy link
Contributor

rakyll commented Feb 13, 2017

Reopening and locking worked, hope it won't be closed again by the bot in the future: #218.

@rakyll
Copy link
Contributor

rakyll commented Feb 13, 2017

Oops, the bot closed it again: #218. I will create a CL against x/build/cmd/pushback at some point.

gopherbot pushed a commit to golang/build that referenced this issue Feb 14, 2017
Updates golang/oauth2#217.

Change-Id: I9d75fa2eb4365a6ff7945b088e7abbee9e1c9027
Reviewed-on: https://go-review.googlesource.com/36933
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codegod2222 added a commit to codegod2222/oauth_go that referenced this issue Nov 25, 2022
Fixes golang/oauth2#217.

Change-Id: I251a74b9b26f6b911333bc5d31d0a96a5734ea60
Reviewed-on: https://go-review.googlesource.com/36914
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants