Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Transport.CancelRequest log message #487

Open
andig opened this issue Mar 22, 2021 · 0 comments
Open

Remove Transport.CancelRequest log message #487

andig opened this issue Mar 22, 2021 · 0 comments

Comments

@andig
Copy link

andig commented Mar 22, 2021

Follow-up to #400: I've just encountered

deprecated: golang.org/x/oauth2: Transport.CancelRequest no longer does anything; use contexts

in the log and asked on the ML: https://groups.google.com/g/golang-nuts/c/-hheka0vc40 since it seems that this message cannot be avoided with the default http.Client:

// For compatibility, the Client will also use the deprecated
// CancelRequest method on Transport if found. New
// RoundTripper implementations should use the Request's Context
// for cancellation instead of implementing CancelRequest.
Timeout time.Duration

While the client is convert by the compatibility promise, oauth2 is imho not.

I'd like to propose to remove the deprecated CancelRequest method.

@andig andig changed the title Remove Transport.CancelRequest Remove Transport.CancelRequest log message Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant