Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transport deprecated method CancelRequest #400

Closed
wants to merge 1 commit into from

Conversation

beornf
Copy link

@beornf beornf commented Dec 2, 2019

As mentioned in issue #271 the CancelRequest method is deprecated and was replaced with context cancellation in Go 1.7. This should do away with the need to store a map of modified requests.

My main motivation for this code cleanup is to allow returning a writable body response in the transport https://golang.org/src/net/http/response.go#L344 needed in websockets and other protocols protected by oauth2.

@gopherbot
Copy link
Contributor

This PR (HEAD: c36076d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/209518 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209518.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/209518.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Beorn Facchini:

Patch Set 1:

I also noticed patch https://go-review.googlesource.com/c/oauth2/+/121438 addresses the same issue in Gerrit. Should I continue with this patch?


Please don’t reply on this GitHub thread. Visit golang.org/cl/209518.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Patch Set 1:

I also noticed patch https://go-review.googlesource.com/c/oauth2/+/121438 addresses the same issue in Gerrit. Should I continue with this patch?

Oh, right. I guess we should just let that one finish. Or I can take it over.


Please don’t reply on this GitHub thread. Visit golang.org/cl/209518.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/209518 has been abandoned.

Done by https://go-review.googlesource.com/c/oauth2/+/121438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants