benchstat: accept io.Writer in FormatHTML, not *bytes.Buffer #2
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the API in-line with that of FormatText and FormatCSV and allows it to be used without necessitating an intermediate buffer. The change is fully backwards compatible and doesn't impose any potential performance cost because `html.Template.Execute` accepts an io.Writer, so any `bytes.Buffer` passed by reference to FormatHTML was already being forced to escape onto the heap. This might have been done this way to avoid questions about how the function should handle errors from Writer, but we already ignore those questions and panic in `FormatCSV`, so it seems reasonable that we would do the same thing here.
|
This PR (HEAD: c5a59e8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/perf/+/211320 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the API in-line with that of
FormatTextandFormatCSVandallows it to be used without necessitating an intermediate buffer. The
change is fully backwards compatible and doesn't impose any potential
performance cost because
html.Template.Executeaccepts anio.Writer,so any
bytes.Bufferpassed by reference to FormatHTML was alreadybeing forced to escape onto the heap.
This might have been done this way to avoid questions about how the
function should handle errors from Writer, but we already ignore those
questions and panic in
FormatCSV, so it seems reasonable that we woulddo the same thing here.