Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/licenses: Increase unidentified words allowed in atc exception #25

Closed

Conversation

zrhoffman
Copy link
Contributor

@zrhoffman zrhoffman commented Apr 2, 2021

Increase the number of unidentified words accepted by the atc-dependency
license exception for package and repo names by 1.

The current atc license exception works for the Apache Traffic Control
master branch, but the 5.1.x release branch license
(https://github.com/apache/trafficcontrol/blob/5.1.x/LICENSE) only has
66% coverage. This CL brings it up to 79%.

For golang/go#44968

Increase the number of unidentified words accepted by the atc-dependency
license exception for package and repo names by 1.

The current atc license exception works for the Apache Traffic Control
master branch, but the 5.1.x release branch license
(https://github.com/apache/trafficcontrol/blob/5.1.x/LICENSE) only has
66% coverage. This CL brings it up to 79%.
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 2, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 0821f01) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/306730 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/306730.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 4: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/306730.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 2, 2021
Increase the number of unidentified words accepted by the atc-dependency
license exception for package and repo names by 1.

The current atc license exception works for the Apache Traffic Control
master branch, but the 5.1.x release branch license
(https://github.com/apache/trafficcontrol/blob/5.1.x/LICENSE) only has
66% coverage. This CL brings it up to 79%.

For golang/go#44968

Change-Id: I594a7bb8ff8383a04baa59abb2b9a2f9c0570d27
GitHub-Last-Rev: 0821f01
GitHub-Pull-Request: #25
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/306730
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/306730 has been merged.

@gopherbot gopherbot closed this Apr 2, 2021
@zrhoffman zrhoffman deleted the atc-dependency-5.1.x-support branch April 6, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
2 participants