Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: add S_IRWXG and S_IRWXO to FreeBSD types #13

Closed
wants to merge 1 commit into from

Conversation

janl
Copy link
Contributor

@janl janl commented Jul 29, 2018

I found this during DataDog/datadog-agent#2079

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 28528:

Patch Set 1:

Patch Set 1:

(1 comment)

Thanks for the note, I figured as much from the comment in the file header.

I’m not at all familiar about how all that works, so any pointers to docs or other guidance appreciated.

I did try futzing with ./mkall.sh but it made a lot of seemingly unrelated changes, so I wasn’t sure it was the right thing to run.

I’ve now pulled out the relevant changes and push -f’d a git amend


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5206:

Patch Set 2:

This should update ztypes_freebsd_386.go and ztypes_freebsd_arm.go as well.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 28528:

Patch Set 3:

latest push includes updates for arm & 386


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 19560:

Patch Set 3: Run-TryBot+1 Code-Review+2

Patch Set 3:

latest push includes updates for arm & 386

Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=12348f16


Please don’t reply on this GitHub thread. Visit golang.org/cl/126620.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 8, 2018
I found this during DataDog/datadog-agent#2079

Change-Id: I51d57e7e3cedb8b23e720bc03f38504dc0ad063d
GitHub-Last-Rev: 4e1c193
GitHub-Pull-Request: #13
Reviewed-on: https://go-review.googlesource.com/126620
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/126620 has been merged.

@gopherbot gopherbot closed this Aug 8, 2018
gopherbot pushed a commit to golang/go that referenced this pull request Aug 21, 2018
Companion PR to golang/sys#13

Change-Id: I097fc97912840eb69ca232eded6ba939de0fead9
GitHub-Last-Rev: f8a8f7d
GitHub-Pull-Request: #26675
Reviewed-on: https://go-review.googlesource.com/126621
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants