-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unix: add S_IRWXG and S_IRWXO to FreeBSD types #13
Conversation
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
Message from Gerrit User 5065: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
9b2f653
to
f149abd
Compare
Message from Gerrit User 28528: Patch Set 1:
Thanks for the note, I figured as much from the comment in the file header. I’m not at all familiar about how all that works, so any pointers to docs or other guidance appreciated. I did try futzing with I’ve now pulled out the relevant changes and Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
Message from Gerrit User 5206: Patch Set 2: This should update ztypes_freebsd_386.go and ztypes_freebsd_arm.go as well. Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
f149abd
to
4e1c193
Compare
Message from Gerrit User 28528: Patch Set 3: latest push includes updates for arm & 386 Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
Message from Gerrit User 19560: Patch Set 3: Run-TryBot+1 Code-Review+2
Thanks Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
Message from Gerrit User 5976: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=12348f16 Please don’t reply on this GitHub thread. Visit golang.org/cl/126620. |
I found this during DataDog/datadog-agent#2079 Change-Id: I51d57e7e3cedb8b23e720bc03f38504dc0ad063d GitHub-Last-Rev: 4e1c193 GitHub-Pull-Request: #13 Reviewed-on: https://go-review.googlesource.com/126620 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This PR is being closed because golang.org/cl/126620 has been merged. |
Companion PR to golang/sys#13 Change-Id: I097fc97912840eb69ca232eded6ba939de0fead9 GitHub-Last-Rev: f8a8f7d GitHub-Pull-Request: #26675 Reviewed-on: https://go-review.googlesource.com/126621 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I found this during DataDog/datadog-agent#2079