unix: fix epoll_event padding on riscv64 #40
Conversation
|
This PR (HEAD: a28d41c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/189877 to see it. Tip: You can toggle comments from me using the |
|
Message from Joel Sing: Patch Set 1: Code-Review+1 Nice find! Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Tobias Klauser: Patch Set 1: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=4aade5cd Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
tonistiigi
force-pushed
the
riscv-epoll-padding
branch
from
a28d41c
to
3302142
Compare
|
This PR (HEAD: 3302142) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/189877 to see it. Tip: You can toggle comments from me using the |
|
Message from Tobias Klauser: Patch Set 2: You'll also need to adjust the PR text to remove the Signed-off-by line in the Gerrit CL (see https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message) Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Tõnis Tiigi: Patch Set 2:
I already did. The msg is updated in the source but seems the bot doesn't pick it up. Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Tobias Klauser: Patch Set 2:
On #40 I still see the Signed-off-by line in the PR description (not the commit message). You'll also need to remove it from there due to Gerrit taking the PR title and description for the git commit message (somewhat weird, I know). Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Tobias Klauser: Patch Set 3: Run-TryBot+1 Code-Review+2 Thank you! Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=4ce1e0b5 Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/189877. |
Change-Id: I88bccf0e671d350f8f57ac4d277adf4081054729 GitHub-Last-Rev: 3302142 GitHub-Pull-Request: #40 Reviewed-on: https://go-review.googlesource.com/c/sys/+/189877 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/189877 has been merged. |
|
Guys, can this be backported to release-branch.go1.13 ? |
|
You use x/sys/unix from a release branch? |
|
Actually K8s pin some dependencies by branch so when they move to Go 1.13, they move to the release-1.13 branch of x/sys. |
|
@gopherbot, please backport. /cc @tklauser |
|
Actually this is already on the Go 1.13 release branch: https://go.googlesource.com/sys/+log/refs/heads/release-branch.go1.13 (3rd one down) |
|
Oh, my bad. I don't know how I missed it looking thru the commits. Sorry Brad. |
No description provided.