New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term: consistently return zeroes on GetSize error #6

Closed

qxxt wants to merge 2 commits into golang:master from qxxt:patch-1

Contributor

qxxt commented Dec 21, 2021 •

edited

All other platform have return value of 0 for error when trying to get
the terminal size while unix have -1. That makes it hard to catch
whether the value passed from it was inserted on purpose.

qxxt added 2 commits

December 21, 2021 18:54


          Consistent error value return for Getsize()

d08250c

All other platform have return value of 0 for error when trying to get the terminal size while unix have -1. That makes it hard to catch whether the value passed from it was inserted on purpose.


          Merge branch 'golang:master' into patch-1

39cb14d

Contributor

gopherbot commented Jun 26, 2023

This PR (HEAD: 39cb14d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/term/+/506235 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Jun 26, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 27, 2023

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 27, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 27, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

qxxt changed the title ~~Consistent error value return for Getsize()~~ term: consistently return zeroes on GetSize error

Contributor

gopherbot commented Jun 27, 2023

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 27, 2023

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/506235.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          term: consistently return zeroes on GetSize error

88fcf87

All other platform have return value of 0 for error when trying to get
the terminal size while unix have -1. That makes it hard to catch
whether the value passed from it was inserted on purpose.

Change-Id: If47d07bd2d4f6cd439ad0ff4958e4095c8e4df9d
GitHub-Last-Rev: 39cb14d
GitHub-Pull-Request: #6
Reviewed-on: https://go-review.googlesource.com/c/term/+/506235
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

Contributor

gopherbot commented Jul 4, 2023

This PR is being closed because golang.org/cl/506235 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment