Skip to content

Commit

Permalink
cmd/go-contrib-init: better GOPATH checkout error message
Browse files Browse the repository at this point in the history
Modify the error message to provide more context if the user is in the
wrong directory. (The default Terminal.app does not do a great job of
showing what directory you are currently in).

Change-Id: Iafcbbd2070ca968863120fb8c4bc15609475cda2
Reviewed-on: https://go-review.googlesource.com/48232
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
kevinburke committed Jul 13, 2017
1 parent 7a94893 commit 6f1996f
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions cmd/go-contrib-init/contrib.go
Expand Up @@ -147,16 +147,20 @@ func checkGoroot() {
}

func checkWorkingDir() {
if *repo == "go" {
if inGoPath() {
log.Fatal("You can't work on Go from within your GOPATH. Please checkout Go outside of your GOPATH")
}
return
}
wd, err := os.Getwd()
if err != nil {
log.Fatal(err)
}
if *repo == "go" {
if inGoPath(wd) {
log.Fatalf(`You can't work on Go from within your GOPATH. Please checkout Go outside of your GOPATH
Current directory: %s
GOPATH: %s
`, wd, os.Getenv("GOPATH"))
}
return
}

gopath := firstGoPath()
if gopath == "" {
Expand Down Expand Up @@ -197,12 +201,7 @@ func exists(path string) (bool, error) {
return true, err
}

func inGoPath() bool {
wd, err := os.Getwd()
if err != nil {
log.Fatal(err)
}

func inGoPath(wd string) bool {
if os.Getenv("GOPATH") == "" {
return false
}
Expand Down

0 comments on commit 6f1996f

Please sign in to comment.