Skip to content

Commit

Permalink
Revert "go/analysis: add Sizes that matches gc size computations"
Browse files Browse the repository at this point in the history
This reverts CL 501495 (commit 5aa6acb).

Reason for revert: Per internal discussion, we should fix go/types.
                   See issue #61035.

Change-Id: Ia63587af701b864acc1b43939954eae76572a407
Reviewed-on: https://go-review.googlesource.com/c/tools/+/506596
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
  • Loading branch information
Robert Griesemer authored and gopherbot committed Jun 27, 2023
1 parent 5aa6acb commit 969078b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 323 deletions.
237 changes: 0 additions & 237 deletions go/analysis/unitchecker/sizes.go

This file was deleted.

85 changes: 0 additions & 85 deletions go/analysis/unitchecker/sizes_test.go

This file was deleted.

2 changes: 1 addition & 1 deletion go/analysis/unitchecker/unitchecker.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func run(fset *token.FileSet, cfg *Config, analyzers []*analysis.Analyzer) ([]re
})
tc := &types.Config{
Importer: importer,
Sizes: sizesFor("gc", build.Default.GOARCH), // assume gccgo ≡ gc?
Sizes: types.SizesFor("gc", build.Default.GOARCH), // assume gccgo ≡ gc?
}
info := &types.Info{
Types: make(map[ast.Expr]types.TypeAndValue),
Expand Down

0 comments on commit 969078b

Please sign in to comment.