gopls: add maxUnimportedPackageNames option that makes the number o…

…f completion candidates for unimported packages configurable
golang · Jun 25, 2023 · d39db52 · d39db52
1 parent fa10359
commit d39db52
Show file tree

Hide file tree

Showing 6 changed files with 272 additions and 94 deletions.
diff --git a/gopls/doc/settings.md b/gopls/doc/settings.md
@@ -233,6 +233,12 @@ fields in completion responses.
 
 Default: `false`.
 
+##### **maxUnimportedPackageNames** *int*
+
+max number of completion candidates for unimported packages.
+
+Default: `5`.
+
 ##### **completionBudget** *time.Duration*
 
 **This setting is for debugging purposes only.**

diff --git a/gopls/internal/lsp/protocol/generate/main.go b/gopls/internal/lsp/protocol/generate/main.go
@@ -132,6 +132,7 @@ func writeserver() {
 	fmt.Fprintln(out, fileHdr)
 	out.WriteString(
 		`import (
+	"bytes"
 	"context"
 	"encoding/json"
 

diff --git a/gopls/internal/lsp/protocol/generate/output.go b/gopls/internal/lsp/protocol/generate/output.go
@@ -101,7 +101,9 @@ func genCase(method string, param, result *Type, dir string) {
 			nm = "ParamConfiguration" // gopls compatibility
 		}
 		fmt.Fprintf(out, "\t\tvar params %s\n", nm)
-		fmt.Fprintf(out, "\t\tif err := json.Unmarshal(r.Params(), &params); err != nil {\n")
+		fmt.Fprintf(out, "\t\tdecoder := json.NewDecoder(bytes.NewReader(r.Params()))\n")
+		fmt.Fprintf(out, "\t\tdecoder.UseNumber()\n")
+		fmt.Fprintf(out, "\t\tif err := decoder.Decode(&params); err != nil {\n")
 		fmt.Fprintf(out, "\t\t\treturn true, sendParseError(ctx, reply, err)\n\t\t}\n")
 		p = ", &params"
 	}