ocagent: convert Int64Data and Float64Data metrics to *wire.Metric. #170

kirbyquerby · 2019-10-08T18:38:06Z

Histogram data still needs to be converted and
timestamps are not attached as they are not yet available.

What works:

convertMetric will now convert Int64Data and Float64Data.

What does not work yet:

Histogram64Int and Histogram64Float will still not be converted.
StartTime and EndTime will not be attached to timeseries and points.
MetricDescriptors will not have a unit attached.
no labels will be attached to timeseries.

Updates golang/go#33819

Histogram data still needs to be converted and timestamps are not attached as they are not yet available.

…eseries

gopherbot · 2019-10-08T18:40:07Z

This PR (HEAD: 3a45823) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/199857 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-08T18:42:03Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-08T20:12:04Z

This PR (HEAD: 4b0eeb5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/199857 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-08T20:17:21Z

Message from Emmanuel Odeke:

Patch Set 2: Run-TryBot+1

(4 comments)

Thank you Nathan and congrats on sending the first major CL! LGTM with some minor nits.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-08T20:17:22Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=62d74b7f

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-08T20:20:52Z

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/ed7e4308/freebsd-amd64-12_0_ae4efe20.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-08T20:25:45Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-09T20:48:43Z

Message from Ian Cottrell:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T01:48:11Z

Message from Nathan Dias:

Patch Set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T01:49:25Z

This PR (HEAD: ae22d45) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/199857 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-10T01:50:19Z

Message from Nathan Dias:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T02:34:38Z

Message from Ian Cottrell:

Patch Set 5: Code-Review+2

Please mention what you would now expect to work and what would not in the cl description, the TODO's in the code say what still needs to be done correctly, but for someone watching the bug having the cl say what the effects are is good. Thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

* rename transform_metrics_to_wire and corresponding test to metrics * return nil from convertMetric() if descriptor and timeseries are nil

gopherbot · 2019-10-10T07:31:29Z

This PR (HEAD: 10820a9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/199857 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-10T07:43:21Z

Message from Emmanuel Odeke:

Patch Set 9: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T07:43:22Z

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4bd78c7d

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T07:44:20Z

Message from Emmanuel Odeke:

Patch Set 9:

Thank you and congrats Nathan, welcome officially to the Go project! Thank you Ian for the review.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T07:46:24Z

Message from Gobot Gobot:

Patch Set 9:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/3322f3e0/freebsd-amd64-12_0_810410c9.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

Histogram data still needs to be converted and timestamps are not attached as they are not yet available. What works: * convertMetric will now convert Int64Data and Float64Data. What does not work yet: * Histogram64Int and Histogram64Float will still not be converted. * StartTime and EndTime will not be attached to timeseries and points. * MetricDescriptors will not have a unit attached. * no labels will be attached to timeseries. Updates golang/go#33819 Change-Id: I65f9af716ba6282e809d0a9d10777d70475e4c83 GitHub-Last-Rev: 10820a9 GitHub-Pull-Request: #170 Reviewed-on: https://go-review.googlesource.com/c/tools/+/199857 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Ian Cottrell <iancottrell@google.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>

gopherbot · 2019-10-10T07:50:25Z

Message from Gobot Gobot:

Patch Set 9: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/199857.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-10T07:51:26Z

This PR is being closed because golang.org/cl/199857 has been merged.

kirbyquerby added 5 commits September 28, 2019 16:19

ocagent: convert Int64Data and Float64Data metrics to *wire.Metric.

573abc5

Histogram data still needs to be converted and timestamps are not attached as they are not yet available.

space between // and comment

63d7198

remove extra newlines

dabce64

inline metric.Int64Data and metric.Float64Data in tests

ab864e7

No longer treating Groups() as labels, added full tests for dataToTim…

4b0eeb5

…eseries

googlebot added the cla: yes label Oct 8, 2019

kirbyquerby force-pushed the convertint64 branch from 3a45823 to 4b0eeb5 Compare October 8, 2019 20:11

address review comments

10820a9

* rename transform_metrics_to_wire and corresponding test to metrics * return nil from convertMetric() if descriptor and timeseries are nil

kirbyquerby force-pushed the convertint64 branch from ae22d45 to 10820a9 Compare October 10, 2019 07:30

gopherbot closed this Oct 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ocagent: convert Int64Data and Float64Data metrics to *wire.Metric. #170

ocagent: convert Int64Data and Float64Data metrics to *wire.Metric. #170

kirbyquerby commented Oct 8, 2019 •

edited

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 9, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

ocagent: convert Int64Data and Float64Data metrics to *wire.Metric. #170

ocagent: convert Int64Data and Float64Data metrics to *wire.Metric. #170

Conversation

kirbyquerby commented Oct 8, 2019 • edited

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 8, 2019

gopherbot commented Oct 9, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

gopherbot commented Oct 10, 2019

kirbyquerby commented Oct 8, 2019 •

edited