x/tools/go/analysis/passes/copylock: detect copylock in multi-assignment #319

ajwans · 2021-05-30T00:02:03Z

The existing implementation does not identify lock copies when doing
multi-assignment, i.e. foo, ok := someMap["key"]

Currently, it will find issue with similar code foo := someMap["key"].

This discrepency is because a return type of Tuple was not considered
when resolving the type of the right hand side of the assignment.

Fixes #45896

gopherbot · 2021-05-30T00:05:00Z

This PR (HEAD: f7e5aec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/323589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-30T00:08:56Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T17:52:39Z

Message from Tim King:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T17:59:17Z

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T17:59:18Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4e0da54d-fa0e-4d59-848e-f6447801336d

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T17:59:18Z

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T17:59:19Z

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/4e0da54d-fa0e-4d59-848e-f6447801336d

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T18:39:34Z

Message from Go Bot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-11T20:13:27Z

This PR (HEAD: c49301b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/323589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-14T21:57:08Z

Message from Tim King:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-14T23:38:32Z

Message from Andrew Wansink:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:21:17Z

Message from Tim King:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:27:50Z

Message from Go Bot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:27:51Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b856e996-f88a-4b1c-b294-d6ddf3c931de

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:27:52Z

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:30:00Z

Message from kokoro:

Patch Set 2: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/b856e996-f88a-4b1c-b294-d6ddf3c931de

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-15T19:58:03Z

Message from Go Bot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-18T23:10:35Z

This PR (HEAD: ac5c6e1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/323589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-18T23:26:12Z

Message from Andrew Wansink:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-21T01:29:48Z

Message from Tim King:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-21T01:35:10Z

Message from Go Bot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-21T01:35:11Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/f626ac6b-1da5-41b9-bbbc-d44c22244ca7

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-21T01:37:41Z

Message from kokoro:

Patch Set 3: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/f626ac6b-1da5-41b9-bbbc-d44c22244ca7

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-21T01:50:43Z

Message from Go Bot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-23T04:56:08Z

Message from Andrew Wansink:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-24T00:23:59Z

Message from Tim King:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-02T17:27:50Z

Message from Go Bot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-02T17:27:51Z

Message from Go Bot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-02T17:27:51Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-02T17:40:12Z

Message from Tim King:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:28:51Z

This PR (HEAD: 0b1f2d0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/323589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-11-03T16:45:04Z

Message from Andrew Wansink:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:48:07Z

Message from Andrew Wansink:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:48:08Z

Message from Tim King:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:54:07Z

Message from Go Bot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:54:08Z

Message from Go Bot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:54:09Z

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/7e26bbf0-6cb9-48d5-ad86-95a8e86f0e7a

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T16:54:10Z

Message from kokoro:

Patch Set 6: gopls-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/7e26bbf0-6cb9-48d5-ad86-95a8e86f0e7a

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T17:27:33Z

Message from Go Bot:

Patch Set 6: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T17:56:08Z

Message from Tim King:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

The existing implementation does not identify lock copies when doing multi-assignment, i.e. foo, ok := someMap["key"] Currently, it will find issue with similar code foo := someMap["key"]. This discrepency is because a return type of Tuple was not considered when resolving the type of the right hand side of the assignment. Fixes #45896

gopherbot · 2021-11-03T18:33:49Z

This PR (HEAD: bb51bdd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/323589 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-11-03T18:36:44Z

Message from Andrew Wansink:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T19:27:13Z

Message from Tim King:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T19:27:14Z

Message from Go Bot:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T19:27:15Z

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/3b508e2f-fa5a-48b5-a75b-e120b2693b9f

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T19:27:15Z

Message from kokoro:

Patch Set 7: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/3b508e2f-fa5a-48b5-a75b-e120b2693b9f

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T19:27:16Z

Message from Go Bot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T20:00:13Z

Message from Andrew Wansink:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T20:27:14Z

Message from Tim King:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

The existing implementation does not identify lock copies when doing multi-assignment, i.e. foo, ok := someMap["key"] Currently, it will find issue with similar code foo := someMap["key"]. This discrepency is because a return type of Tuple was not considered when resolving the type of the right hand side of the assignment. Fixes #45896 Change-Id: I93266dbd03a301ff558d826ff4fe70fc0344cb77 GitHub-Last-Rev: bb51bdd GitHub-Pull-Request: #319 Reviewed-on: https://go-review.googlesource.com/c/tools/+/323589 Run-TryBot: Tim King <taking@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Tim King <taking@google.com> Trust: Robert Findley <rfindley@google.com>

gopherbot · 2021-11-03T20:56:21Z

Message from Robert Findley:

Patch Set 7: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/323589.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T21:02:02Z

This PR is being closed because golang.org/cl/323589 has been merged.

google-cla bot added the cla: yes label May 30, 2021

ajwans mentioned this pull request May 30, 2021

x/tools/go/analysis/passes/copylock: does not detect tuple copies golang/go#45896

Closed

ajwans force-pushed the fix_copylocks branch from f7e5aec to c49301b Compare June 11, 2021 20:11

ajwans force-pushed the fix_copylocks branch from c49301b to ac5c6e1 Compare September 18, 2021 23:08

ajwans force-pushed the fix_copylocks branch from 0b1f2d0 to bb51bdd Compare November 3, 2021 18:31

gopherbot closed this Nov 3, 2021

buglloc mentioned this pull request Jan 11, 2022

x/tools/go/analysis/passes/copylock: allow assignment to blank identifier golang/go#50551

Closed

x/tools/go/analysis/passes/copylock: detect copylock in multi-assignment #319

x/tools/go/analysis/passes/copylock: detect copylock in multi-assignment #319

Conversation

ajwans commented May 30, 2021

gopherbot commented May 30, 2021

gopherbot commented May 30, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 11, 2021

gopherbot commented Jun 14, 2021

gopherbot commented Jun 14, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Jun 15, 2021

gopherbot commented Sep 18, 2021

gopherbot commented Sep 18, 2021

gopherbot commented Sep 21, 2021

gopherbot commented Sep 21, 2021

gopherbot commented Sep 21, 2021

gopherbot commented Sep 21, 2021

gopherbot commented Sep 21, 2021

gopherbot commented Sep 23, 2021

gopherbot commented Sep 24, 2021

gopherbot commented Nov 2, 2021

gopherbot commented Nov 2, 2021

gopherbot commented Nov 2, 2021

gopherbot commented Nov 2, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021