Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize the example_text function #33

Closed
wants to merge 1 commit into from

Conversation

aerostitch
Copy link

Hi!

When you generate some flavored text like Markdown it would be really nice to reuse directly the builtin functions instead of having to duplicate chunks of code like I had to do in davecheney/godoc2md#20
This PR adds an example_test2 function that supports a custom title for the example and custom elements to put around the code block (so we can add " go" and "")
Let me know what you think about it.

Thanks
Joseph

@gopherbot
Copy link
Contributor

This PR (HEAD: dd60cff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/tools/+/106981 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/106981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Proposals should go via https://golang.org/s/proposal and not via new code.

Please open a proposal if you wish to add new functionality.


Please don’t reply on this GitHub thread. Visit golang.org/cl/106981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joseph Herlant:

Patch Set 1:

Hi Brad,

Sorry for that.
The proposal has been created: golang/go#24862

Thanks
Joseph


Please don’t reply on this GitHub thread. Visit golang.org/cl/106981.
After addressing review feedback, remember to publish your drafts!

@aerostitch aerostitch closed this Apr 16, 2018
WenzheLiu pushed a commit to WenzheLiu/tools that referenced this pull request Nov 29, 2019
* commit '182017f2b5364c0049671bffb449bcb93d9acaba':
  remove old ico
  update playground url
  support c/c++ (not tested)
  change logo icon; home page add link to Search, Playground and parent folder; slide page add link to home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants