Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls/internal/lsp/source: put context first in extracted functions #440

Closed
wants to merge 4 commits into from
Closed

gopls/internal/lsp/source: put context first in extracted functions #440

wants to merge 4 commits into from

Conversation

vikstrous2
Copy link
Contributor

@vikstrous2 vikstrous2 commented Jun 14, 2023 •
edited

Put the context first when extracting functions/methods

Fixes golang/go#60738

@google-cla
Copy link

google-cla bot commented Jun 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 0846fbb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/503295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@vikstrous2
gopls/internal/lsp/source: put context first in extracted functions
a979900 
Put the context first when extracting functions/methods

Fixes golang/go#60738
@vikstrous2 vikstrous2 changed the title put the context first when extracting functions/methods gopls/internal/lsp/source: put context first in extracted functions Jun 17, 2023
@gopherbot
Copy link
Contributor

This PR (HEAD: a979900) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/503295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 2: Code-Review+2

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: eefe098) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/503295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Viktor Stanchev:

Patch Set 4:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 4: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 4:

Kokoro presubmit build queued for golang/tools/gopls-legacy/presubmit
Logs at: http://sponge2.corp.google.com/6403b73c-3072-4974-b118-d071ea556fac

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/6403b73c-3072-4974-b118-d071ea556fac

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 4: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/6403b73c-3072-4974-b118-d071ea556fac

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joedian Reid:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5267944) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/503295 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Viktor Stanchev:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 5: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 5:

Kokoro presubmit build queued for golang/tools/gopls-legacy/presubmit
Logs at: http://sponge2.corp.google.com/a8d3ca46-209b-42ba-b4ad-3bcb6b84216a

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a8d3ca46-209b-42ba-b4ad-3bcb6b84216a

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 10, 2023
@vikstrous2 @findleyr
gopls/internal/lsp/source: put context first in extracted functions
538a6e9 
Put the context first when extracting functions/methods

Fixes golang/go#60738

Change-Id: I04f86355ffa0c7b080a8aea82baf0947722b6440
GitHub-Last-Rev: 5267944
GitHub-Pull-Request: #440
Reviewed-on: https://go-review.googlesource.com/c/tools/+/503295
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 5: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/a8d3ca46-209b-42ba-b4ad-3bcb6b84216a

Please don’t reply on this GitHub thread. Visit golang.org/cl/503295.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/503295 has been merged.

@gopherbot gopherbot closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vikstrous2 @gopherbot