Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for golang linter install failing during docker image build #52

Closed
wants to merge 1 commit into from

Conversation

vinayb21
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@vinayb21
Copy link
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@gopherbot
Copy link
Contributor

This PR (HEAD: 72bfe77) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/143541 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143541.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 24096:

Patch Set 1:

Should we do this ? Considering we only support 1.10 and 1.11 right now.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143541.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 13550:

Patch Set 1: Code-Review-1

This was done on purpose: https://go-review.googlesource.com/c/142896

Leaving to Robert, but this seems like the wrong thing to do. Unless there is a good reason to revert that CL, which hasn't been brought up.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143541.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 24096:

Patch Set 1:

Patch Set 1: Code-Review-1

This was done on purpose: https://go-review.googlesource.com/c/142896

Leaving to Robert, but this seems like the wrong thing to do. Unless there is a good reason to revert that CL, which hasn't been brought up.

We should probably then remove the isAlias function altogether. In a different CL ofcourse.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143541.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5210:

Patch Set 1: Code-Review-2

Patch Set 1:

Patch Set 1: Code-Review-1

This was done on purpose: https://go-review.googlesource.com/c/142896

Leaving to Robert, but this seems like the wrong thing to do. Unless there is a good reason to revert that CL, which hasn't been brought up.

We should probably then remove the isAlias function altogether. In a different CL ofcourse.

We're only supporting 3 releases (the current one in the works, 1.11, and 1.10). We're not going to introduce this. Also, isAlias is gone, so I don't know that this CL compiles.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143541.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/143541 has been abandoned.

@gopherbot gopherbot closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants