Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tour: mixing terminology "rune" and "character" #497

Open
rnewsham opened this issue May 29, 2018 · 2 comments · May be fixed by golang/website#203
Open

tour: mixing terminology "rune" and "character" #497

rnewsham opened this issue May 29, 2018 · 2 comments · May be fixed by golang/website#203

Comments

@rnewsham
Copy link

Context: https://tour.golang.org/basics/11

on tutorial page 11, it mentions "rune" (uint32), but on page 15 it is called "character" with no indication that it means the same thing
@bgadrian
Copy link
Contributor

bgadrian commented Jun 7, 2018

I think the page /15 should be modified to "Unicode code point" to be more specific, although the terms are used as synonyms from what I saw ( https://blog.golang.org/strings ).

@crisman
Copy link

crisman commented Mar 3, 2023

The language spec (https://go.dev/ref/spec#Constants) says:

There are boolean_constants, rune_constants, integer_constants,
floating-point_constants, complex_constants, and string_constants.
Rune, integer, floating-point, and complex constants are collectively
called numeric_constants.

Rune constants are included in numeric constants, so neither is need here.

crisman added a commit to crisman/golang_website that referenced this issue Mar 3, 2023
@crisman
tour: character removed in deference to rune
75f76a9 
In tour/basics/15 ("Constants") the word "character" is both new (not
used in the tour before this slide) and confusing as it is not the Go
way to talk about runes. Since "numeric values" is called out a few
words later (which includes rune constants), neither rune nor character
is needed here.

Remove odd word "character" to avoid confusing readers with unneeded
non-Go terminology.

Fixes golang/tour#497
Fixes golang/tour#1151
@crisman crisman linked a pull request Mar 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tour: character removed in deference to rune crisman/golang_website
3 participants
@crisman @bgadrian @rnewsham