Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: local tour instructions incomplete #8

Closed
brianshumate opened this issue Apr 20, 2016 · 11 comments
Closed

tour: local tour instructions incomplete #8

brianshumate opened this issue Apr 20, 2016 · 11 comments

Comments

@brianshumate
Copy link

Context: https://tour.golang.org/welcome/3

The instructions suggest that downloading and installing Go allows the user to run the tour locally, but they do not mention that Go Tour project must also be installed.

Perhaps suggesting installation of Go and Go Tour with a link to the Go Tour project README for their installation and execution instructions would be helpful for folks wanting to run the tour locally.

@adg
Copy link
Contributor

adg commented Apr 20, 2016

Dupe of golang/go#15183, but I'll leave this open as the canonical bug.

There I wrote:

Maybe we should link to a wiki page that explains both approaches?

@retnuh
Copy link

retnuh commented May 20, 2016

The tour should definitely be updated to include the proper instructions for running locally. As is, it leaves a pretty bad "first time user" experience to have to go to StackOverflow or wherever to figure out how to do it. I imagine that a bunch of potential users will just bail at that point.

@jeffjen
Copy link

jeffjen commented May 29, 2016

I wanted to add that while trying to write some instructions on setting up gotour locally, I got a 403 on the websocket connection.

I understand that running the gotour with host:port other then localhost is dangerous, but my workspace and tutorial is running in a VM.

here is the log message I got

bad websocket origin: http://localhost:8080

@tleb
Copy link

tleb commented Aug 17, 2016

Just for those coming from search engines who get the same error message: you need to access http://127.0.0.1:3999 not http://localhost:3999 if you haven't change the -http option on gotour.

@brettgoulder
Copy link

I just got caught by this when trying to learn go.

The binary release doesn't seem to include gotour.

Here's what the binary produces:

~ /usr/local/go/bin/go tool
addr2line
api
asm
cgo
compile
cover
dist
doc
fix
link
nm
objdump
pack
pprof
trace
vet
yacc

 ~ /usr/local/go/bin/go version
go version go1.7.1 darwin/amd64

Installing the gotour package and running gotour resolved it.

@adg
Copy link
Contributor

adg commented Oct 11, 2016

cc @broady

@robphoenix
Copy link
Contributor

Is the underlying issue here resolved by the instructions added in this commit by @adg: 7671a9e ?
If so is it worth adding a link in https://tour.golang.org/welcome/3 to these instructions? I had a look at the Go wiki but these instructions aren't there. Copying them there would mean there would be two sources of info to keep updated, so I assume it's easier to link to the README here?
I can open a CL for this if I've not got the wrong end of the stick.

@retnuh
Copy link

retnuh commented Jun 6, 2017

I think adding a link is probably the way to go, but I'd like to point out that the README is confusing, too. It says to run go tool tour before you actually install it. It would make more sense to have the instructions to install it, and then run it, wouldn't it?

@robphoenix
Copy link
Contributor

I think the instructions in the README are correct; If you install a binary release of Go, suggested first, then you can run go tool tour straight away, otherwise if Go has been installed from source you will need to go get it.

@retnuh
Copy link

retnuh commented Jun 6, 2017

Ah that would make sense. I probably did a brew install golang (or whatever) to install go, which would have built it from source.

@ALTree
Copy link
Member

ALTree commented Sep 7, 2020

go tool tour has been removed from the toolchain and now the instructions at that page say 1) install go 2) go get the tour 3) run the binary; which seems clear enough to me (and more importantly there's no more confusion between using the go tool copy or the external repository).

Closing here.

@ALTree ALTree closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants