dap: Do not parse program on modes that do not require it

golang · Jul 21, 2021 · 2a95d3c · 2a95d3c
1 parent 8a80a86
commit 2a95d3c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -554,7 +554,7 @@
                   "replay",
                   "core"
                 ],
-                "description": "One of `auto`, `debug`, `test`, `exec`, `remote`, `replay`, `core`. In `auto` mode, the extension will choose either `debug` or `test` depending on active editor window.",
+                "description": "One of `auto`, `debug`, `test`, `exec`, `replay`, `core`. In `auto` mode, the extension will choose either `debug` or `test` depending on active editor window.",
                 "default": "auto"
               },
               "traceDirPath": {

diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
@@ -517,10 +517,17 @@ export function parseProgramArgSync(
 	launchAttachArgs: vscode.DebugConfiguration
 ): { program: string; dirname: string; programIsDirectory: boolean } {
 	const program = launchAttachArgs.program;
+	let programIsDirectory = false;
+
+	if (launchAttachArgs.mode === 'replay') {
+		// Skip program parsing on modes that do not require a program
+		return { program: '', dirname: '', programIsDirectory: programIsDirectory };
+	}
+
 	if (!program) {
 		throw new Error('The program attribute is missing in the debug configuration in launch.json');
 	}
-	let programIsDirectory = false;
+
 	try {
 		programIsDirectory = fs.lstatSync(program).isDirectory();
 	} catch (e) {