[release] prepare v0.39.1 release

3eafcb4 CHANGELOG.md: update for v0.39.1
9e7f858 src/goDeveloperSurvey: update survey link and dates
75770e1 package.json: add gopls.start_debugging
5f5a875 build/Dockerfile: skip global typescript, vsce installation
0de0e11 build: remove unused, outdated cloudbuild config
3b2da9a package.json: prepare for the v0.40.0 dev cycle
fb1dce6 package.json: align snippetsPreventQuickSuggestions with VS Code default

Change-Id: I9e1f5d40b5128c4c829850139aef92d26c18907f

CHANGELOG.md

@@ -1,3 +1,8 @@
+## v0.39.1 - 17 Jul, 2023
+
+This is a point release to update the link for the upcoming Go developer survey.
+A list of changes can be found in the full [commit history](https://github.com/golang/vscode-go/compare/v0.39.1...v0.39.0).
+
 ## v0.39.0 - 12 Jun, 2023
 
 We are in the process of removing legacy language features that were replaced by `gopls` since early 2021. The versions released after September 2023 will no longer offer features like code completion, navigation, documentation, formatting, and refactoring if the language server is disabled. In this release, we are showing deprecation notification messages if you are using the legacy language features. ([Issue 2799](https://github.com/golang/vscode-go/issues/2799))

build/Dockerfile

@@ -26,8 +26,7 @@ ENV DEBIAN_FRONTEND noninteractive
 ENV NODE_OPTIONS --dns-result-order=ipv4first
 
 RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
-RUN npm install -g typescript @vscode/vsce
 
 USER node
 WORKDIR /workspace
-ENTRYPOINT ["build/all.bash"]
+ENTRYPOINT ["build/all.bash"]

docs/commands.md

@@ -159,6 +159,10 @@ Toggles between file in current active editor and the corresponding test file.
 
 Toggle the display of vulnerability analysis in dependencies.
 
+### `Go: Start language server's maintainer interface`
+
+Start the Go language server's maintainer interface (a web server).
+
 ### `Go: Add Tags To Struct Fields`
 
 Add tags configured in go.addTags setting to selected struct using gomodifytags

package.json

@@ -1,7 +1,7 @@
 {
   "name": "go",
   "displayName": "Go",
-  "version": "0.39.0",
+  "version": "0.39.1",
   "publisher": "golang",
   "description": "Rich Go language support for Visual Studio Code",
   "author": {
@@ -36,7 +36,7 @@
   ],
   "scripts": {
     "clean": "rm -rf ./dist/* && rm *.vsix",
-    "package": "vsce package",
+    "package": "npx vsce package",
     "vscode:prepublish": "npm run compile",
     "bundle": "esbuild src/goMain.ts debugAdapter=src/debugAdapter/goDebug.ts --bundle --outdir=dist --external:vscode --format=cjs --platform=node",
     "bundle-dev": "npm run bundle -- --sourcemap",
@@ -216,8 +216,7 @@
         "editor.formatOnSave": true,
         "editor.codeActionsOnSave": {
           "source.organizeImports": true
-        },
-        "editor.suggest.snippetsPreventQuickSuggestions": false
+        }
       }
     },
     "commands": [
@@ -397,6 +396,11 @@
         "title": "Go: Toggle Vulncheck",
         "description": "Toggle the display of vulnerability analysis in dependencies."
       },
+      {
+        "command": "go.languageserver.maintain",
+        "title": "Go: Start language server's maintainer interface",
+        "description": "Start the Go language server's maintainer interface (a web server)."
+      },
       {
         "command": "go.add.tags",
         "title": "Go: Add Tags To Struct Fields",

src/commands/index.ts

@@ -21,6 +21,7 @@ export { runBuilds } from './runBuilds';
 export { showCommands } from './showCommands';
 export { startDebugSession } from './startDebugSession';
 export { startLanguageServer } from './startLanguageServer';
+export { startGoplsMaintainerInterface } from './startLanguageServer';
 export { toggleGCDetails } from './toggleGCDetails';
 
 type CommandCallback<T extends unknown[]> = (...args: T) => Promise<unknown> | unknown;

src/commands/startLanguageServer.ts

@@ -138,3 +138,19 @@ function shouldActivateLanguageFeatures() {
 	}
 	return true;
 }
+
+export const startGoplsMaintainerInterface: CommandFactory = (ctx, goCtx) => {
+	return () => {
+		if (!goCtx.languageServerIsRunning) {
+			vscode.window.showErrorMessage(
+				'"Go: Start language server\'s maintainer interface" command is available only when the language server is running'
+			);
+			return;
+		}
+		vscode.commands.executeCommand('gopls.start_debugging', {}).then(undefined, (reason) => {
+			vscode.window.showErrorMessage(
+				`"Go: Start language server's maintainer interface" command failed: ${reason}`
+			);
+		});
+	};
+};

src/goDeveloperSurvey.ts

@@ -12,8 +12,8 @@ import { daysBetween, flushSurveyConfig, getStateConfig, minutesBetween, timeMin
 import { GoExtensionContext } from './context';
 
 // Start and end dates of the survey.
-export const startDate = new Date('Jan 18 2023 00:00:00 GMT');
-export const endDate = new Date('Feb 8 2023 00:00:00 GMT');
+export const startDate = new Date('Jul 20 2023 00:00:00 GMT');
+export const endDate = new Date('Aug 10 2023 00:00:00 GMT');
 
 // DeveloperSurveyConfig is the set of global properties used to determine if
 // we should prompt a user to take the gopls survey.
@@ -123,8 +123,8 @@ export function shouldPromptForSurvey(now: Date, cfg: DeveloperSurveyConfig): De
 
 export async function promptForDeveloperSurvey(cfg: DeveloperSurveyConfig, now: Date): Promise<DeveloperSurveyConfig> {
 	const selected = await vscode.window.showInformationMessage(
-		`Help shape Go’s future! Would you like to help ensure that Go is meeting your needs
-by participating in this 10-minute Go Developer Survey (2023 Winter) before ${endDate.toDateString()}?`,
+		`"Help shape Go’s future! Would you like to help ensure that Go is meeting your needs
+by participating in this 10-minute Go Developer Survey (2023 H2) before ${endDate.toDateString()}?`,
 		'Yes',
 		'Remind me later',
 		'Never'
@@ -139,7 +139,7 @@ by participating in this 10-minute Go Developer Survey (2023 Winter) before ${en
 			{
 				cfg.lastDateAccepted = now;
 				cfg.prompt = true;
-				const surveyURL = 'https://google.qualtrics.com/jfe/form/SV_bNnbAtFZ0vfRTH8?s=p';
+				const surveyURL = 'https://google.qualtrics.com/jfe/form/SV_4Vi4bNaMQhQdqSi?s=p';
 				await vscode.env.openExternal(vscode.Uri.parse(surveyURL));
 			}
 			break;

src/goMain.ts

@@ -103,6 +103,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<ExtensionA
 
 	const registerCommand = commands.createRegisterCommand(ctx, goCtx);
 	registerCommand('go.languageserver.restart', commands.startLanguageServer);
+	registerCommand('go.languageserver.maintain', commands.startGoplsMaintainerInterface);
 
 	await commands.startLanguageServer(ctx, goCtx)(RestartReason.ACTIVATION);