Skip to content

Commit

Permalink
src/goLanguageServer.ts: restart if go.toolsEnvVars changes
Browse files Browse the repository at this point in the history
go.toolsEnvVars setting affects how gopls launches.
See src/goEnv.ts toolExecutionEnvironment.

Updates #628

Change-Id: I6294af2d4dd1822b7dfbe571532c6f2d18089608
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254370
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
  • Loading branch information
hyangah committed Sep 11, 2020
1 parent f8bce8c commit c23df8f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/goLanguageServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,9 @@ export function watchLanguageServerConfiguration(e: vscode.ConfigurationChangeEv
e.affectsConfiguration('go.useLanguageServer') ||
e.affectsConfiguration('go.languageServerFlags') ||
e.affectsConfiguration('go.languageServerExperimentalFeatures') ||
e.affectsConfiguration('go.alternateTools')
e.affectsConfiguration('go.alternateTools') ||
e.affectsConfiguration('go.toolsEnvVars')
// TODO: Should we check http.proxy too? That affects toolExecutionEnvironment too.
) {
restartLanguageServer();
}
Expand Down

0 comments on commit c23df8f

Please sign in to comment.