-
Notifications
You must be signed in to change notification settings - Fork 730
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src/goDebugConfiguration: take program verbatim with external adapter
As a fix for #1677, the extension massages launch configurations to start dlv from the package directory and locate 'program' to be relative from the package directory. This heuristic does not work well if dlv dap adapter is launched externally so dlv runs from other directory. Until `delveCWD` or a similar mechanism that allows to control where delve runs the build, we take the launch configuration verbatim and avoid any mutation. Relative paths are resolved as described in the descriptions in package.json. This changes only the internal mechanics. Fixes #1793 Change-Id: Ic651be25a692dbb23a51707d5ebc274f22a3c532 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/351272 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Polina Sokolova <polina@google.com>
- Loading branch information
Showing
2 changed files
with
59 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters