Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fails to parse the new go dev version string (1.17+) #1464

Closed
hyangah opened this issue Apr 30, 2021 · 1 comment
Closed

tools: fails to parse the new go dev version string (1.17+) #1464

hyangah opened this issue Apr 30, 2021 · 1 comment
Assignees
@hyangah
Labels
FrozenDueToAge
Milestone
Untriaged

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 30, 2021

From go 1.17 dev cycle, dev version started to include the go base version in the version output. golang/go#44960 The extension's version string parser needs adjustment.
@hyangah hyangah added this to the v0.25.0 milestone Apr 30, 2021
@gopherbot gopherbot modified the milestones: v0.25.0, Untriaged Apr 30, 2021
@hyangah hyangah self-assigned this Apr 30, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/315853 mentions this issue: src/util: adjust go dev version regex

lggomez pushed a commit to lggomez/vscode-go-1 that referenced this issue May 6, 2021
@hyangah @lggomez
src/util: adjust go dev version regex
c3ab262 
During the go1.17 dev cycle, the dev version string format was
changed to include the go base version.
See golang/go#44960.
Recognize the new format.

We can improve the version comparison logic utilizing this further
but this does not utilize it yet.

Fixes golang#1464

Change-Id: If2084ad9d86cb8b4c0f59c36b1347c0188452189
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/315853
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@golang golang locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge
Projects
None yet
Milestone
Untriaged
Development

No branches or pull requests
2 participants
@hyangah @gopherbot