Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Profile feature is broken in vscode 1.63 #2048

Closed
hyangah opened this issue Feb 1, 2022 · 4 comments
Closed

test: Profile feature is broken in vscode 1.63 #2048

hyangah opened this issue Feb 1, 2022 · 4 comments
Labels
FrozenDueToAge go-test issues related to go test support (test output, test explorer, ...) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.31.1

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 1, 2022

vscode-go version: v0.31.0
vscode version: 1.63.2

[2022-02-01 17:31:30.445] [exthost] [error] Error: Extension 'golang.go' CANNOT use API proposal: quickPickSeparators.
Its package.json#enabledApiProposals-property declares: [] but NOT quickPickSeparators.
 The missing proposal MUST be added and you must start in extension development mode or use the following command line switch: --enable-proposed-api golang.go
	at E (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:80833)
	at Object.showQuickPick (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:104:30178)
	at GoTestProfiler.configure (/Users/hakim/.vscode/extensions/golang.go-0.31.0/dist/goMain.js:79492:44)
	at /Users/hakim/.vscode/extensions/golang.go-0.31.0/dist/goMain.js:79757:43
	at r._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:95:31080)
	at r.$executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:95:31622)
	at t._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:99:13802)
	at t._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:99:13486)
	at t._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:99:12148)
	at t._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:99:10826)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:99:8922
	at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
	at r.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:18942)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:114:34341
	at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
	at r.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:18942)
	at n._receiveMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:23523)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:21057
	at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:66:1712)
	at w.acceptChunk (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:15770)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:74:14900
	at Socket.T (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:114:13813)
	at Socket.emit (events.js:315:20)
	at addChunk (internal/streams/readable.js:309:12)
	at readableAddChunk (internal/streams/readable.js:284:9)
	at Socket.Readable.push (internal/streams/readable.js:223:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:188:23) go.test.captureProfile {"value":"golang.go","_lower":"golang.go"}

This is due to our use of name kind, that conflicts with the property included in the currently proposed QuickPick separator API.

microsoft/vscode#138745 suggests renaming the property on our side may resolve the issue.

cc @firelizzard18
@hyangah hyangah added NeedsFix The path to resolution is known, but the work has not been done. go-test issues related to go test support (test output, test explorer, ...) labels Feb 1, 2022
@hyangah hyangah modified the milestones: v0.33.0, v0.32.0 Feb 1, 2022
@hyangah hyangah changed the title test: Profile feature is broken due to conflicts with a proposed vscode API (quickPickSeparators) test: Profile feature is broken in vscode 1.63 Feb 1, 2022
hyangah added a commit to hyangah/vscode-go that referenced this issue Feb 1, 2022
@hyangah
src/goTest: avoid a name conflicting with the proposed quickpick api
78e971d 
src/goTest used an extended quickpick type that adds a custom property
'kind' to specify the profile type. Unfortunately, that conflicts with
the proposed API added during vscode 1.63 dev cycle and breaks the
extension's profile feature.

Rename ours to 'profilekind'.

Fixes golang#2048

Change-Id: Iedd1c5f32cdbc8438e203f8989f28bfcaf1c04b4
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/382334 mentions this issue: src/goTest: avoid a name conflicting with the proposed quickpick api

@hyangah hyangah modified the milestones: v0.32.0, v0.31.1 Feb 4, 2022
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/383219 mentions this issue: [release] src/goTest: avoid a name conflicting with the proposed quickpick api

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/382334 mentions this issue: src/goTest: avoid a name conflicting with the proposed quickpick api

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/383219 mentions this issue: [release] src/goTest: avoid a name conflicting with the proposed quickpick api

gopherbot pushed a commit that referenced this issue Feb 8, 2022
@hyangah
[release] src/goTest: avoid a name conflicting with the proposed quic…
c8584f4 
…kpick api

src/goTest used an extended quickpick type that adds a custom property
'kind' to specify the profile type. Unfortunately, that conflicts with
the proposed API added during vscode 1.63 dev cycle and breaks the
extension's profile feature.

Rename ours to 'profilekind'.

And reenabled the profile feature tests disabled due to 1858.
(but these tests don't exercise the affected code path - quickpick
UI interaction)

Fixes #2048

Updates #1858

Change-Id: Iedd1c5f32cdbc8438e203f8989f28bfcaf1c04b4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/382334
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Ethan Reesor <ethan.reesor@gmail.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
(cherry picked from commit 037e8a3)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/383219
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge go-test issues related to go test support (test output, test explorer, ...) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.31.1
Development

No branches or pull requests
2 participants
@hyangah @gopherbot