Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move files in docs to Wiki #2094

Closed
hyangah opened this issue Mar 8, 2022 · 12 comments
Closed

docs: move files in docs to Wiki #2094

hyangah opened this issue Mar 8, 2022 · 12 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 8, 2022

Background

In microsoft/vscode-go#3168 we moved all the contents from Wiki to the docs directory.

The rationals behind the move were

  • GitHub Wiki repo is separate from the regular github repo and does not allow convenient ways of reviewing PRs and inspecting changes. (Wiki: update FAQ, modules support, misc... microsoft/vscode-go#3148).
  • We don't want to allow Wiki contents to be editable without proper review process. GitHub restricts search engines' crawling of Wiki contents if the edit permission is not restricted. Permit search engines to index Github wikis community/community#4992 And we've seen Wikis without proper review process often suffering from vandalism or inaccuracy.
  • Users without edit permissions cannot easily contribute to the Wiki contents, like other markdown files in the repo using GitHub's Markdown edit/preview feature. So, bar for contribution is high.

With the move, however, we had to give up GitHub's Wiki UI that allows more customization & search &
index options suitable for documentations. Documentation inside the main project repo is not easily
searchable either.

Proposal

Follow the github.com/microsoft/vscode project's wiki page setup. (https://github.com/microsoft/vscode/wiki vs https://github.com/Microsoft/vscode-wiki)

  • Maintain the canonical version of wiki pages in vscode-go repo's docs directory.
    • All updates must go through the proper review process.
    • Users can update contents from github's UI and PR workflows.
    • Document autogeneration scripts will continue to work.
  • GitHub Action workflow will copy the data in docs directory to github.com/golang/vscode-go.wiki repo.
  • Access to github.com/golang/vscode-go/wiki.git is restricted so search engines can crawl them.

Note

  1. We may want to move some of user-facing settings/features/tutorials to more publicly visible webpage. Even after then, wiki will continue to serve as a place to host
  • internal documentation for project management (triage process, release process, project milestone, contribution guide, etc)
  • less polished, transient tips & tricks
  • compatibility info
  • links to proposals or design docs

cc @golang/tools-team

EDIT: (2022-04-17) Originally I proposed to have a separate repo to host documentation. But that complicates automated documentation generation with which we wanted to maintain consistency between the current code & the settings. Keeping two separate repositories isn't ideal either. Instead, I changed this proposal to use docs directory as the place we keep all the wiki page contents, and mirror the contents to the wiki page.

@gopherbot gopherbot added this to the Untriaged milestone Mar 8, 2022
@suzmue suzmue modified the milestones: Untriaged, On Deck Mar 14, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/400355 mentions this issue: .github/workflows: add wiki.yml that copies docs/ to wiki repo

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/400356 mentions this issue: docs: add Home/footer/sidebar/faq, move release_plan.md

hyangah added a commit to hyangah/vscode-go that referenced this issue Apr 18, 2022
For golang#2094

Change-Id: Ifdba178d749dad2c9e15428148688e297d1aba14
hyangah added a commit to hyangah/vscode-go that referenced this issue Apr 18, 2022
For golang#2094

Change-Id: I2170fe3755214f1b6390f3292b2a3601797ae359
gopherbot pushed a commit that referenced this issue Apr 19, 2022
For #2094

Change-Id: Ifdba178d749dad2c9e15428148688e297d1aba14
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/400355
Reviewed-by: Jamal Carvalho <jamal@golang.org>
gopherbot pushed a commit that referenced this issue Apr 19, 2022
For #2094

Change-Id: I2170fe3755214f1b6390f3292b2a3601797ae359
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/400356
Reviewed-by: Suzy Mueller <suzmue@golang.org>
hyangah added a commit to hyangah/vscode-go that referenced this issue Apr 20, 2022
Unlike markdown style links for local md file references, wiki links
need to be the url of the wiki pages. In GitHub wiki, links to local
md files of file.md form send users to in the local disk
and wiki links are different. In GitHub Wiki, if links to local md files
send users to raw.github.com pages that serve the raw text content.

https://stackoverflow.com/questions/34804531/in-github-wiki-absolute-links-to-markdown-leads-to-raw-githubusercontent

To avoid this, rewrite local md file uris included in all the md files
in dir.

And, call this from github action wiki.yml workflow before pushing
to the wiki repo.

Fixes golang#2094

Change-Id: Iaeb756a4c14cd98544a1a58ace859b6f48a358ce
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401194 mentions this issue: tools/docs2wiki: tool that rewrites local .md file urls with wiki links

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/401196 mentions this issue: tools/docs2wiki: remove redundant title

gopherbot pushed a commit that referenced this issue Apr 21, 2022
Unlike markdown style links for local md file references, wiki links
need to be the url of the wiki pages. In GitHub wiki, links to local
md files of file.md form send users to in the local disk
and wiki links are different. In GitHub Wiki, if links to local md files
send users to raw.github.com pages that serve the raw text content.

https://stackoverflow.com/questions/34804531/in-github-wiki-absolute-links-to-markdown-leads-to-raw-githubusercontent

To avoid this, rewrite local md file uris included in all the md files
in dir.

And, call this from github action wiki.yml workflow before pushing
to the wiki repo.

Updates #2094

Change-Id: Iaeb756a4c14cd98544a1a58ace859b6f48a358ce
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401194
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Apr 21, 2022
Wiki page assumes its file name is the title of the page.
Remove the redundant title header from the content.
We assume the first line of the file that starts with # is the title header.

Adjust some .md file contents to work with the heuristic.

For #2094

Change-Id: Id873556af8aaf0ae5a06ada073fdbbcd5f44628c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/401196
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
nelsonjchen added a commit to nelsonjchen/github-wiki-see-rs that referenced this issue Apr 25, 2022
@nelsonjchen
Copy link

nelsonjchen commented May 9, 2022

May I make a suggestion? It might be a good idea to make the generated markdown for the Wikis include a custom "Edit on GitHub" link that auto-forks/opens the source markdown for editing.

As an example of another organization's approach to the wiki issue, see https://libgdx.com/wiki/ and search for "Edit on GitHub" on that page for an example. It should be possible to have that as the "Edit on GitHub" link in the markdown that's pushed to the GitHub Wiki instead of the generic and non-specific "send a pull request" in the footer.

Example: tokio-rs/website#109


I run https://github-wiki-see.page so I'm very aware of the challenges that organizations and individuals have in trying to get their GitHub Wiki content officially indexable. Please let me know if you or your team have any questions.

hyangah added a commit to hyangah/vscode-go that referenced this issue Jun 14, 2022
As suggested in
golang#2094 (comment)

Since we rely on GitHub's default wiki feature instead of GH pages or
custom hosting sites, options are limited currently.

Updates golang#2094

Change-Id: I3090ee79c9794e2b56fc78fa564770266767f3dd
hyangah added a commit to hyangah/vscode-go that referenced this issue Jun 14, 2022
And change the use of https://github.com/golang/vscode-go/blob/master/docs
from files in docs directory to relative paths so tools like
docs2wiki can translate them consistently.

Fixes golang#2094

Change-Id: I185f590d3d48704d648edcf4ad58b9aee5414690
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/412057 mentions this issue: README.md: use wiki links instead of blob/master/docs

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/412055 mentions this issue: tools/docs2wiki: place source edit link instead of static footer

hyangah added a commit to hyangah-test/vscode-docs that referenced this issue Jun 14, 2022
gopherbot pushed a commit that referenced this issue Jun 14, 2022
As suggested in
#2094 (comment)

Since we rely on GitHub's default wiki feature instead of GH pages or
custom hosting sites, options are limited currently.

Updates #2094

Change-Id: I3090ee79c9794e2b56fc78fa564770266767f3dd
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/412055
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/412384 mentions this issue: tools/docs2wiki: place source edit link instead of static footer

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/412386 mentions this issue: README.md: use wiki links instead of blob/master/docs

@1989shack
Copy link

Integrated platforms across the internet, Domains Registrar, Domains WHOIS Records, Servers Hosting Platform databases system Admin flow

@leonardoadame
Copy link

.github/ISSUE_TEMPLATE

@leonardoadame
Copy link

@golang golang locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants