Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: enable dlv-dap by default for remote attach in Nightly #2168

Closed
polinasok opened this issue Apr 6, 2022 · 4 comments
Closed

debug: enable dlv-dap by default for remote attach in Nightly #2168

polinasok opened this issue Apr 6, 2022 · 4 comments
Assignees
@polinasok
Labels
debug/remote issues related to remote debugging support Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone
vscode-go/backlog

Comments

@polinasok
Copy link
Contributor

See #1517 for inspiration.
@gopherbot gopherbot added this to the Untriaged milestone Apr 6, 2022
@hyangah
Copy link
Contributor

hyangah commented Apr 6, 2022

Given the very low number of users who use Nightly AND use the remote debugging, shouldn't we consider more aggressive approach to reach out to more users? I.e., prompt users about this new remote debugging option and provide an option to change a setting that affects the default behavior with one click?

@suzmue
Copy link
Contributor

suzmue commented Apr 7, 2022

@hyangah It definitely seems likely that turning it on in nightly will not be sufficient to get enough data to enable it by default overall, but I think it still makes sense as an easy first stuff that we can then follow up with a prompt to all Go extension users that use debugging.

@suzmue suzmue modified the milestones: Untriaged, On Deck Apr 7, 2022
@polinasok
Copy link
Contributor Author

I had the same thought. These things are not mutually exclusive.

@polinasok polinasok added debug/remote issues related to remote debugging support Debug Issues related to the debugging functionality of the extension. labels Apr 7, 2022
@polinasok polinasok mentioned this issue Apr 9, 2022
Closed
@polinasok polinasok self-assigned this Apr 22, 2022
@polinasok polinasok mentioned this issue Apr 22, 2022
Closed
3 tasks
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/402220 mentions this issue: src/goDebugConfiguration: fix debugAdapter default selection

gopherbot pushed a commit that referenced this issue Apr 26, 2022
@hyangah
src/goDebugConfiguration: fix debugAdapter default selection
33d46b5 
The intention of cl/399077 is to choose 'legacy' as the default
for 'remote' mode when we are not in preview mode, while choose
'dlv-dap' when we are in preview mode. The condition was reversed.
CI couldn't detect the bug because it was running only in
preview mode.

For #2168
Fixes #2215

Change-Id: I31b353abce29e52270cc589916c61aa5712258e3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/402220
Reviewed-by: Polina Sokolova <polina@google.com>
@golang golang locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@polinasok polinasok

Labels
debug/remote issues related to remote debugging support Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Milestone
vscode-go/backlog
Development

Successfully merging a pull request may close this issue.

src/goDebugConfiguration: default to dlv-dap for remote in preview mode polinasok/vscode-go-1
4 participants
@hyangah @suzmue @gopherbot @polinasok