Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.33.0 #2212

Closed
25 tasks done
hyangah opened this issue Apr 25, 2022 · 8 comments
Closed
25 tasks done

Release 0.33.0 #2212

hyangah opened this issue Apr 25, 2022 · 8 comments
Labels
FrozenDueToAge
Milestone
v0.33.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 25, 2022 •
edited

Release candidate (April 28, 2022)

  • Announce the release, leave enough time for teams to surface any last minute issues that need to get in before freeze. Make sure debugger and gopls teams are looped in as well.
  • Create a milestone with the issues that are fixed by this release
  • Update master for the release
    • Update hardcoded latest version for gopls
    • Update CHANGELOG.md
      • Make sure the "Thanks" section is up-to-date
      • Check the Markdown rendering to make sure everything looks good
  • Update release for the release
    • Create a branch against release for a pull request
    • Merge changes from master to prepare for the release
    • Change the version in package.json from a -dev suffix
    • Run npm install to make sure package-lock.json is up-to-date
    • Update the license file ($ tools/license.sh; mv LICENSE.prod LICENSE)
  • Check the Long Tests status is green. Otherwise, fix the tests, send cls for review, submit them, and repeat.
  • Perform manual smoke tests
  • Create new version tag for X.XX.X-rc.1 at gerrit’s vscode-go repo management page
  • Go to the release page https://github.com/golang/vscode-go/releases and check if the new release candidate is up. If necessary, you can manually edit the comment by clicking the “Edit” button. Don’t mutate uploaded vsix.
  • Ask editor team and contributors to this release to test the release candidate

Final (May 1, 2022)

  • Tag the new release
  • Update the release description with CHANGELOG contents
  • Close the milestone

Prepare for the Next Release

  • Update master post-release
    • Bump the version number to the next monthly ("X.XX.X-dev") release in the master branch
      • package.json
      • package-lock.json
@gopherbot gopherbot added this to the Untriaged milestone Apr 25, 2022
@hyangah hyangah modified the milestones: Untriaged, v0.33.0 Apr 25, 2022
@polinasok
Copy link
Contributor

polinasok commented Apr 25, 2022 •
edited

Update hardcoded latest version for dlv-dap and gopls

Hmm, I thought we don't use dlv-dap anymore.

@hyangah
Copy link
Contributor Author

hyangah commented Apr 26, 2022 •
edited

RC is available here - https://github.com/golang/vscode-go/releases/tag/v0.33.0-rc.2
Help for checking the following functionalities is greatly appreciated

@polinasok

@suzmue

  • go-outline is no longer required
  • test codelens, generate tests for function, test explorer work without them
  • there is no prompt when there is no go-outline
  • when gopls is disabled, go-outline appears

@dlipovetsky

  • test explorer can handle go.mod with comments

@hyangah

  • gopls opt out survey prompt works as expected
  • go vulncheck command preview

@jamalc

  • go explorer does not show when non-go repo is open
  • go explorer shows expected UI

Thanks!

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/402634 mentions this issue: CHANGELOG.md: v0.33.0 change log

@suzmue
Copy link
Contributor

suzmue commented Apr 27, 2022 •
edited

For go-outline, when I set "go.useLanguageServer": false in the settings, it did not pop up to install go-outline though it looked like gopls was still running indicated by the lightning bolt in the status bar. Once it was reloaded I was asked to download go-outline.

Update: am not seeing this behavior again . Will file an issue if i notice it again. I don't think its related specifically to the go-outline, but with switching between all legacy and gopls.

@hyangah
Copy link
Contributor Author

hyangah commented Apr 27, 2022

@suzmue nice finding - I think that is due to the issue described here #1896 (comment) I think. Gopls crashes during shutdown golang/go#52543 and leaves the extension in a broken state.

Seems like any change that affects gopls makes this happen. It's a preexisting bug, but is much easier to hit if users play with the Go Explorer UI (experimental). Should we delay release until we have a workaround?
@golang/tools-team

gopherbot pushed a commit that referenced this issue Apr 28, 2022
@hyangah
CHANGELOG.md: v0.33.0 change log
95b8c3a 
For #2212

Change-Id: I6ce72a04c2e9b9b35acfad106b6f4744de9dad40
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/402634
Reviewed-by: Polina Sokolova <polina@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@hyangah
Copy link
Contributor Author

hyangah commented Apr 29, 2022

We decided to hold off the release till early Monday.
For the issue Suzy discovered in #2212 (comment), we filed issue #2222, the fix is available in the latest nightly, but we may release the fix as v0.33.1.

@hyangah
Copy link
Contributor Author

hyangah commented May 2, 2022

Release is out https://github.com/golang/vscode-go/releases/tag/v0.33.0

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/403474 mentions this issue: package.json: change version to v0.34.0-dev

@golang golang locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.33.0
Development

No branches or pull requests
4 participants
@hyangah @suzmue @gopherbot @polinasok