Please add an option to disable warnings from simplifycompositelit

[rajatsing]

If you have a question, please ask it on the #vscode or #vscode-go channels in Gophers Slack](https://invite.slack.golangbridge.org/messages/vscode).

Is your feature request related to a problem? Please describe.
I keep on getting warnings like this redundant type from array, slice, or map composite literal simplifycompositelit.

I don't know how to disable this warning.

Describe the solution you'd like
Please write a feature so that I can disable the warnings like above from the VScode's settings.json.

Describe alternatives you've considered
There is no fix to this problem AFAIK.

Additional context
There is no issue in the code's logic or any other error whatsoever. These warnings are pretty distracting.

[hyangah]

@rajatsingh25aug Please share your go related settings.

If you are using the Go language server ("go.useLanguageServer": true), specific analysis can be turned off like the followings.

"gopls": {
   "analyses": {
      "simplifycompositelit": false, 
   }
}

See https://github.com/golang/tools/blob/master/gopls/doc/settings.md#analyses-mapstringbool
(also note the settings syntax may change in the future)

Even though I hope the default set of diagnostics can help writing more readable code,
if you think that's too distracting, you can completely turn off any diagnostics

    "go.languageServerExperimentalFeatures": {
        "diagnostics": false
    }

[rajatsing]

@hyangah My settings.json looks like this.

{
    "go.useLanguageServer": true,
    "go.buildOnSave": "package",
    "go.lintFlags": ["--disable=all"],
    "terminal.integrated.fontFamily": "Source Code Pro for Powerline",
    "files.trimTrailingWhitespace": true,
    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "markdown.extension.toc.unorderedList.marker": "*",
    "markdown.extension.toc.levels": "2..2",
    "workbench.iconTheme": "eq-material-theme-icons-darker",
    "workbench.colorTheme": "Winter is Coming (Dark Black - No Italics)",
    "window.zoomLevel": 2,
    "python.jediEnabled": false,
    "workbench.editor.showTabs": true,
}

[hyangah]

Thanks @rajatsingh25aug for sharing the settings.

You are using the language server ("go.useLanguageServer": true), so the settings change I described in my previous comment will do what you want.

We plan to improve the discoverability of the settings. (#197)

[stamblerre]

Just to add one more note here - you can configure your editor to automatically fix all of those errors on save by adding the following to your settings:

"[go]": {
	"editor.codeActionsOnSave": {
		"source.fixAll": true,
	}
}

[rajatsing]

@hyangah The settings that you provided didn't work. :/

Am I doing something wrong?.

[hyangah]

@rajatsingh25aug That "unknown configuration setting" error is fine - that's working as intended and gopls will process it. We didn't promote the gopls section as a recognized setting yet because gopls is still in alpha.

Is the settings.json file saved?

From my quick testing, it should work.

Before:

After:

[rajatsing]

@hyangah So I have applied the settings again and restarted the vscode again. Killed all the running process related to vscode from the background and it worked. 💯

I was facing this issue for a long time. Thank you for being so prompt for helping out. 👍

[hyangah]

@rajatsingh25aug good to hear that the problem solved.

Ideally gopls should pick up the new configuration automatically and the vscode restart shouldn't be necessary. If not, I hope the future release should handle this better.

Enjoy Go programming!