workspaceFolderBasename not populated in go.goroot setting #2310

bentekkie · 2022-06-30T18:56:12Z

What version of Go, VS Code & VS Code Go extension are you using?

Version Information

Run go version to get version of Go from the VS Code integrated terminal.
- go1.19-pre4 cl/455575533 +12f49fe0ed linux/amd64
Run gopls -v version to get version of Gopls from the VS Code integrated terminal.
- v0.8.4
Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.
- 1.68.1
  30d9c6cd9483b2cc586687151bcbcd635f373630
  x64
Check your installed extensions to get the version of the VS Code Go extension
- v0.34.0
Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.
- Checking configured tools....
  GOBIN: undefined
  toolsGopath:
  gopath: /usr/local/google/home/bentekkie/go
  GOROOT: /usr/lib/google-golang
  PATH: /usr/local/google/home/bentekkie/depot_tools:/usr/local/google/home/bentekkie/.cargo/bin:/usr/local/google/home/bentekkie/.local/bin:/usr/local/google/home/bentekkie/.local/bin:/usr/lib/google-golang/bin:/usr/local/buildtools/java/jdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/usr/local/google/home/bentekkie/go/bin
go: /usr/lib/google-golang/bin/go: go version go1.19-pre4 cl/455575533 +12f49fe0ed linux/amd64

gotests: /usr/local/google/home/bentekkie/go/bin/gotests (version: v1.6.0 built with go: go1.19-pre4)
gomodifytags: /usr/local/google/home/bentekkie/go/bin/gomodifytags (version: v1.16.0 built with go: go1.19-pre4)
impl: /usr/local/google/home/bentekkie/go/bin/impl (version: v1.1.0 built with go: go1.19-pre4)
goplay: /usr/local/google/home/bentekkie/go/bin/goplay (version: v1.0.0 built with go: go1.19-pre4)
dlv: /usr/bin/dlv (version: unknown - )
golint: /usr/local/google/home/bentekkie/go/bin/golint (version: v0.0.0-20210508222113-6edffad5e616 built with go: go1.19-pre4)
gopls: /usr/local/google/home/bentekkie/go/bin/gopls (version: v0.8.4 built with go: go1.19-pre4)

go env
Workspace Folder (master): /usr/local/google/home/bentekkie/Workspace/re-client/master
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bentekkie/.cache/go-build"
GOENV="/usr/local/google/home/bentekkie/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/bentekkie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bentekkie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/google-golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19-pre4 cl/455575533 +12f49fe0ed"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3745075455=/tmp/go-build -gno-record-gcc-switches"

Workspace Folder (statustoolhttp): /usr/local/google/home/bentekkie/Workspace/re-client/statustoolhttp
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bentekkie/.cache/go-build"
GOENV="/usr/local/google/home/bentekkie/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/bentekkie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bentekkie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/google-golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19-pre4 cl/455575533 +12f49fe0ed"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build884252437=/tmp/go-build -gno-record-gcc-switches"

Workspace Folder (gvisor): /usr/local/google/home/bentekkie/Workspace/re-client/gvisor
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bentekkie/.cache/go-build"
GOENV="/usr/local/google/home/bentekkie/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/bentekkie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bentekkie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/google-golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19-pre4 cl/455575533 +12f49fe0ed"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build428995912=/tmp/go-build -gno-record-gcc-switches"

Workspace Folder (version-bump): /usr/local/google/home/bentekkie/Workspace/re-client/version-bump
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bentekkie/.cache/go-build"
GOENV="/usr/local/google/home/bentekkie/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/bentekkie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bentekkie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/google-golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19-pre4 cl/455575533 +12f49fe0ed"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2116730961=/tmp/go-build -gno-record-gcc-switches"

Workspace Folder (reproxystatus): /usr/local/google/home/bentekkie/Workspace/re-client/reproxystatus
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bentekkie/.cache/go-build"
GOENV="/usr/local/google/home/bentekkie/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/bentekkie/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/usr/local/google/home/bentekkie/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/google-golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19-pre4 cl/455575533 +12f49fe0ed"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1371867421=/tmp/go-build -gno-record-gcc-switches"

Share the Go related settings you have added/edited

"settings": {
        "go.goroot": "${workspaceFolder}/bazel-${workspaceFolderBasename}/external/go_sdk",
        "go.toolsEnvVars": {
            "GOPACKAGESDRIVER": "/usr/local/google/home/bentekkie/.tools/gopackagesdriver.sh"
        },
        "go.enableCodeLens": {
            "references": false,
            "runtest": false
        },
        "gopls": {
            "build.directoryFilters": [
                "-bazel-bin",
                "-bazel-out",
                "-bazel-testlogs",
                "-bazel-mypkg",
                "-docker"
            ],
            "formatting.local": "github.com/my/mypkg",
            "ui.completion.usePlaceholders": true,
            "ui.semanticTokens": true,
            "ui.codelenses": {
                "gc_details": false,
                "regenerate_cgo": false,
                "generate": false,
                "test": false,
                "tidy": false,
                "upgrade_dependency": false,
                "vendor": false
            },
        },
        "go.useLanguageServer": true,
        "go.buildOnSave": "off",
        "go.lintOnSave": "off",
        "go.vetOnSave": "off",
        "bazel.enableCodeLens": true,
        "gitlens.remotes": [
            {
                "type": "Gerrit",
                "domain": "team"
            }
        ],
        "[go]": {
            "editor.formatOnSave": true,
            "editor.codeActionsOnSave": {
                "source.fixAll": false,
                "source.organizeImports": false
            }
        },
        "go.lintTool": "golint",
        "go.formatTool": "gofmt",
        "editor.formatOnSave": true,
    }

Describe the bug

I used the ${workspaceFolderBasename} variable in the go.goroot settings entry and it was not populated.
I expected it to be populated as ${workspaceFolder} is correctly populated

Steps to reproduce the behavior:

Use ${workspaceFolderBasename} in go.goroot settings entry
See error. Example error:

go.goroot setting is ignored. /usr/local/google/home/bentekkie/Workspace/re-client/master/bazel-${workspaceFolderBasename}/external/go_sdk is not a valid GOROOT directory.

The text was updated successfully, but these errors were encountered:

bentekkie · 2022-06-30T19:01:16Z

I think this is due to only ${workspaceFolder} being handled in

vscode-go/src/util.ts

Line 623 in ff8fb94

    
           inputPath = inputPath.replace(/\${workspaceFolder}|\${workspaceRoot}/g, workspaceFolder);

hyangah · 2022-07-06T14:21:28Z

VSCode does not support variables resolution in settings.json microsoft/vscode#2809. As a workaround, the extension has its own hack to resolve a couple of frequently used variables. workspaceFolderBasename is not one of them.

@bentekkie Yes, that's the right place. Contribution is welcome!

gopherbot · 2022-07-06T14:37:16Z

Change https://go.dev/cl/416194 mentions this issue: Substitute workspaceFolderBasename variable into extension settings

gopherbot added this to the Untriaged milestone Jun 30, 2022

hyangah added the HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors. label Jul 6, 2022

hyangah modified the milestones: Untriaged, vscode-go/unplanned Jul 6, 2022

bentekkie mentioned this issue Jul 6, 2022

Substitute workspaceFolderBasename variable into extension settings #2322

Closed

hyangah modified the milestones: vscode-go/unplanned, v0.35.0 Jul 13, 2022

gopherbot closed this as completed in 180bbce Jul 13, 2022

findleyr mentioned this issue Aug 8, 2022

Environment Variable interpolation in settings.json #2395

Open

golang locked and limited conversation to collaborators Jul 13, 2023

gopherbot added the FrozenDueToAge label Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

workspaceFolderBasename not populated in go.goroot setting #2310

workspaceFolderBasename not populated in go.goroot setting #2310

bentekkie commented Jun 30, 2022

bentekkie commented Jun 30, 2022

hyangah commented Jul 6, 2022

gopherbot commented Jul 6, 2022

workspaceFolderBasename not populated in go.goroot setting #2310

workspaceFolderBasename not populated in go.goroot setting #2310

Comments

bentekkie commented Jun 30, 2022

What version of Go, VS Code & VS Code Go extension are you using?

Share the Go related settings you have added/edited

Describe the bug

Steps to reproduce the behavior:

bentekkie commented Jun 30, 2022

hyangah commented Jul 6, 2022

gopherbot commented Jul 6, 2022