Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: support completion/suggestion in debug console #3134

Open
shellwhale opened this issue Jan 16, 2024 · 4 comments
Open

debug: support completion/suggestion in debug console #3134

shellwhale opened this issue Jan 16, 2024 · 4 comments
Labels
FeatureRequest HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. upstream-tools Issues that are caused by problems in the tools that the extension depends on.
Milestone
vscode-go/unplanned

Comments

@shellwhale
Copy link

What version of Go, VS Code & VS Code Go extension are you using?

Version Information
  • Run go version to get version of Go from the VS Code integrated terminal.
    • go version go1.21.6 windows/amd64
  • Run gopls -v version to get version of Gopls from the VS Code integrated terminal.
    • Build info

golang.org/x/tools/gopls v0.14.2
golang.org/x/tools/gopls@v0.14.2 h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc=
github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
github.com/google/go-cmp@v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y=
golang.org/x/mod@v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
golang.org/x/sync@v0.4.0 h1:zxkM55ReGkDlKSM+Fu41A+zmbZuaPVbGMzvvdUPznYQ=
golang.org/x/sys@v0.14.0 h1:Vz7Qs629MkJkGyHxUlRHizWJRG2j8fbQKjELVSNhy7Q=
golang.org/x/telemetry@v0.0.0-20231114163143-69313e640400 h1:brbkEFfGwNGAEkykUOcryE/JiHUMMJouzE0fWWmz/QU=
golang.org/x/text@v0.13.0 h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k=
golang.org/x/tools@v0.14.1-0.20231114185516-c9d3e7de13fd h1:Oku7E+OCrXHyst1dG1z10etCTxewCHXNFLRlyMPbh3w=
golang.org/x/vuln@v1.0.1 h1:KUas02EjQK5LTuIx1OylBQdKKZ9jeugs+HiqO5HormU=
honnef.co/go/tools@v0.4.5 h1:YGD4H+SuIOOqsyoLOpZDWcieM28W47/zRO7f+9V3nvo=
mvdan.cc/gofumpt@v0.4.0 h1:JVf4NN1mIpHogBj7ABpgOyZc65/UUOkKQFkoURsz4MM=
mvdan.cc/xurls/v2@v2.4.0 h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc=
go: go1.21.0

  • Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.

    • 1.85.1
      0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
      x64

  • Check your installed extensions to get the version of the VS Code Go extension

    • v0.40.1

  • Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.

    • go: C:\Users\shellwhale\scoop\shims\go.exe: go version go1.21.0 windows/amd64

    gopls: C:\Users\shellwhale\go\bin\gopls.exe (version: v0.14.2 built with go: go1.21.0)
    gotests: not installed
    gomodifytags: not installed
    impl: not installed
    goplay: not installed
    dlv: C:\Users\shellwhale\go\bin\dlv.exe (version: v1.21.0 built with go: go1.21.0)
    staticcheck: C:\Users\shellwhale\go\bin\staticcheck.exe (version: v0.4.3 built with go: go1.21.0)

Describe the bug

Debug Console Suggestions are not working

Steps to reproduce the behavior:

image

Here is an example of debug console suggestions working with the Python debugger

image
@gopherbot gopherbot added this to the Untriaged milestone Jan 16, 2024
@shellwhale
Copy link
Author

It looks like there is already Delve support for this go-delve/delve#3004

@hyangah
Copy link
Contributor

hyangah commented Jan 17, 2024

The delve feature is for dlv cli. I don't know how this can be implemented on top of DAP. Or is there VS Code specific capability to utilize?

@hyangah hyangah added upstream-vscode Issues that are by problems in VS Code itself. FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors. labels Jan 17, 2024
@hyangah hyangah changed the title Debug Console Suggestions are not working debug: support completion/suggestion in debug console Jan 18, 2024
@hyangah
Copy link
Contributor

hyangah commented Jan 18, 2024

https://microsoft.github.io/debug-adapter-protocol//specification.html#Requests_Completions

Delve DAP currently does not support this capability. cc @suzmue

@hyangah hyangah added upstream-tools Issues that are caused by problems in the tools that the extension depends on. and removed upstream-vscode Issues that are by problems in VS Code itself. labels Jan 18, 2024
@diegolatorre116
Copy link

This would be a great feature! It would greatly improve the user experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest HelpWanted Issues that are not prioritized by the maintainers. Help is requested from community contributors. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. upstream-tools Issues that are caused by problems in the tools that the extension depends on.
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @shellwhale @diegolatorre116