Add auto-complete for local variables #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
reviewed
May 13, 2022
pkg/terminal/terminal.go
Outdated
| case "print", "whatis": | ||
| localVars, err := t.client.ListLocalVariables( | ||
| api.EvalScope{GoroutineID: -1, Frame: t.cmds.frame, DeferredCall: 0}, | ||
| t.loadConfig(), |
There was a problem hiding this comment.
use api.LoadConfig{} so we don't load as much, also the trie should be cached at least until a command is executed (i.e. cleared before the promptForInput call).
There was a problem hiding this comment.
Thank you for the advice! I reworked the code so to cache the local variables trie.
aarzilli
reviewed
May 17, 2022
pkg/terminal/terminal.go
Outdated
| @@ -279,6 +289,19 @@ func (t *Term) Run() (int, error) { | |||
| _, _ = t.client.GetState() | |||
|
|
|||
| for { | |||
| localVars, err := t.client.ListLocalVariables( | |||
There was a problem hiding this comment.
What I was thinking was only clearing the cache here (locs = nil) but filling it in the completer function (if locs == nil { call ListLocalVariables, etc... })
There was a problem hiding this comment.
Sorry, I misunderstood your comment above. You meant a lazy loading of the cache in the completer. Seems reasonable, I'm gonna fix it. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto-complete for local variables when using
printorwhatiscommands.