-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: embed signed vscgo binaries in the extension #3186
Milestone
Comments
Change https://go.dev/cl/571575 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Apr 5, 2024
For golang/vscode-go#3186 Change-Id: I684e222cc018b18ad0c173522dfd70cb3b34e0ca Reviewed-on: https://go-review.googlesource.com/c/build/+/571575 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Change https://go.dev/cl/587735 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 24, 2024
Signing service expects zip as input. Pack the binary in a zip file. The file name is <randomnumber>-<platform>-vscgo.zip. For golang/vscode-go#3186 Change-Id: I7d91dfbd2b5f0c4386421c2abfe77df254b392fb Reviewed-on: https://go-review.googlesource.com/c/build/+/587735 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up of #3182
Then, revert the change https://go.dev/cl/565679 to enable vscgo on windows.
The text was updated successfully, but these errors were encountered: