Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/debugging.md: update on newly available traditional remote debugging via DAP #1920

Closed
wants to merge 2 commits into from
Closed

docs/debugging.md: update on newly available traditional remote debugging via DAP #1920

wants to merge 2 commits into from

Conversation

polinasok
Copy link
Contributor

Updates #1861

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 30, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: 0a9b1e5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/367854 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/367854.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 4a15622) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/367854 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Dec 3, 2021
@polinasok
docs/debugging.md: update on newly available traditional remote debug…
6320e8b 
…ging via DAP

Updates #1861

Change-Id: Icc133623362b98d16fc0cc9fe0f235e4241a928b
GitHub-Last-Rev: 4a15622
GitHub-Pull-Request: #1920
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/367854
Reviewed-by: Polina Sokolova <polina@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/367854.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/367854 has been merged.

@gopherbot gopherbot closed this Dec 3, 2021
@polinasok polinasok deleted the remoteDocs branch December 8, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polinasok @gopherbot