New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: add go.showWelcome #2704

Closed

cuining wants to merge 1 commit into golang:master from cuining:master

Contributor

cuining commented Mar 16, 2023

Control whether to show the Welcome on first install


          package.json: add go.showWelcome

d10a282

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Collaborator

gopherbot commented Mar 17, 2023

This PR (HEAD: d10a282) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/477178 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Collaborator

gopherbot commented Mar 17, 2023

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Mar 28, 2023

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Apr 6, 2023

Message from 崔宁:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented May 16, 2023

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented May 17, 2023

Message from Suzy Mueller:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented May 17, 2023

Message from Suzy Mueller:

Patch Set 1: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Jun 6, 2023

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/477178.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          package.json: add go.showWelcome

99f78ff

This new setting controls whether to show the Welcome
on first install.

Based on GitHub-Pull-Request: #2704
Hana Kim ran `go run tools/generate.go` to update
docs/settings.md.

Change-Id: I30a4c5fd6066b4c5e3052ba3d75e47e6b52a4a76
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501208
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>

Collaborator

gopherbot commented Jun 8, 2023

This PR is being closed because golang.org/cl/477178 has been abandoned.

obsolete by https://go-review.git.corp.google.com/c/vscode-go/+/501208

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment