Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/goTest: fix multifile suite test fails to debug #3128

Closed
wants to merge 2 commits into from
Closed

src/goTest: fix multifile suite test fails to debug #3128

wants to merge 2 commits into from

Conversation

Cr4zySheep
Copy link
Contributor

@Cr4zySheep Cr4zySheep commented Jan 14, 2024 •
edited
Loading

I have resumed the pull request #2415 and added the missing tests.

Here is the original description:

Collect a packages suites and maps their name with the caller function. This mapping is
used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes #2414

@google-cla Google CLA
Copy link

google-cla bot commented Jan 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Cr4zySheep Cr4zySheep force-pushed the cr4zysheep/fix_debug_multifile_test_suite branch from cf78607 to b1e7ab7 Compare January 14, 2024 11:22
@Cr4zySheep Cr4zySheep marked this pull request as ready for review January 14, 2024 11:24
@gopherbot
Copy link
Collaborator

This PR (HEAD: b1e7ab7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/555676.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Loïc M.:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@morremeyer morremeyer mentioned this pull request Jan 16, 2024
Open
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 9c2e3fb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/555676.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Cr4zySheep Cr4zySheep force-pushed the cr4zysheep/fix_debug_multifile_test_suite branch from 9c2e3fb to 1d6148c Compare January 21, 2024 13:37
@gopherbot
Copy link
Collaborator

This PR (HEAD: 1d6148c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/555676.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Cr4zySheep Cr4zySheep force-pushed the cr4zysheep/fix_debug_multifile_test_suite branch from 1d6148c to 306b9e5 Compare January 28, 2024 11:24
@gopherbot
Copy link
Collaborator

This PR (HEAD: 306b9e5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/555676.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Cr4zySheep Cr4zySheep force-pushed the cr4zysheep/fix_debug_multifile_test_suite branch from 306b9e5 to 0fa9525 Compare January 28, 2024 11:51
@gopherbot
Copy link
Collaborator

This PR (HEAD: 0fa9525) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/555676.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Loïc M.:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/59a217f7-3c1f-4916-bb69-c734a1e0d8bd

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/59a217f7-3c1f-4916-bb69-c734a1e0d8bd

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/59a217f7-3c1f-4916-bb69-c734a1e0d8bd

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Than McIntosh:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/555676.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 12, 2024
@Cr4zySheep @gopherbot
src/goTest: fix multifile suite test fails to debug
7bfbcaf 
I have resumed the pull request #2415 and added the missing tests.

Here is the original description:

Collect a packages suites and maps their name with the caller function. This mapping is
used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes #2414

Change-Id: Id6ac5d153fa1dbcdb7591b2bd0ee78bfa95686c6
GitHub-Last-Rev: 0fa9525
GitHub-Pull-Request: #3128
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/555676
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/555676 has been merged.

@gopherbot gopherbot closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to debug a suite test that is in a different file than the caller test
3 participants
@Cr4zySheep @gopherbot @nirhaas