Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/cometbft/cometbft: GHSA-555p-m4v6-cqxv #2585

Closed
GoVulnBot opened this issue Feb 28, 2024 · 3 comments
Assignees
Labels
excluded: NOT_A_VULNERABILITY This is not a vulnerability.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-555p-m4v6-cqxv, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/cometbft/cometbft <= 0.38.5

Cross references:

See doc/triage.md for instructions on how to triage this report.

modules:
    - module: github.com/cometbft/cometbft
      versions:
        - {}
      vulnerable_at: 0.38.5
      packages:
        - package: github.com/cometbft/cometbft
summary: |-
    ASA-2024-004: Default configuration param for Evidence may limit window of
    validity
ghsas:
    - GHSA-555p-m4v6-cqxv
references:
    - advisory: https://github.com/cometbft/cometbft/security/advisories/GHSA-555p-m4v6-cqxv
    - advisory: https://github.com/advisories/GHSA-555p-m4v6-cqxv

@jba jba self-assigned this Feb 28, 2024
@jba
Copy link
Contributor

jba commented Mar 2, 2024

The report says that "a default configuration in CometBFT has been found to be small for common use cases" and refers to EvidenceParams. But the DefaultEvidenceParams function that supplies these defaults has not been changed in two years.

@jba jba added the excluded: NOT_A_VULNERABILITY This is not a vulnerability. label Mar 5, 2024
@jba
Copy link
Contributor

jba commented Mar 5, 2024

Our rationale for that label is that govulncheck has nothing to base a report on. It would give false positives to anyone who adjusted the defaults appropriately, as well as anyone who used the defaults in a situation where they made sense.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/569495 mentions this issue: data/excluded: batch add 11 excluded reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: NOT_A_VULNERABILITY This is not a vulnerability.
Projects
None yet
Development

No branches or pull requests

3 participants