x/vulndb: potential Go vuln in github.com/cometbft/cometbft: CVE-2023-34451

[GoVulnBot]

CVE-2023-34451 references github.com/cometbft/cometbft, which may be a Go module.

Description:
CometBFT is a Byzantine Fault Tolerant (BFT) middleware that takes a state transition machine and replicates it on many machines. The mempool maintains two data structures to keep track of outstanding transactions: a list and a map.
These two data structures are supposed to be in sync all the time in the sense that the map tracks the index (if any) of the transaction in the list. In v0.37.0, and v0.37.1, as well as in v0.34.28, and all previous releases of the CometBFT repo2, it is possible to have them out of sync. When this happens, the list may contain several copies of the same transaction. Because the map tracks a single index, it is then no longer possible to remove all the copies of the transaction from the list. This happens even if the duplicated transaction is later committed in a block. The only way to remove the transaction is by restarting the node.

The above problem can be repeated on and on until a sizable number of transactions are stuck in the mempool, in order to try to bring down the target node. The problem is fixed in releases v0.34.29 and v0.37.2. Some workarounds are available. Increasing the value of cache_size in config.toml makes it very difficult to effectively attack a full node. Not exposing the transaction submission RPC's would mitigate the probability of a successful attack, as the attacker would then have to create a modified (byzantine) full node to be able to perform the attack via p2p.

References:

• NIST: https://nvd.nist.gov/vuln/detail/CVE-2023-34451
• JSON: https://github.com/CVEProject/cvelist/tree/f14d8739758bd488ae84d05117df2f8c6d7e4497/2023/34xxx/CVE-2023-34451.json
• advisory: GHSA-w24w-wp77-qffm
• fix: Prevent a transaction to appear twice in the mempool cometbft/cometbft#890
• fix: mempool no gossip back tendermint/tendermint#2778
• Imported by: https://pkg.go.dev/github.com/cometbft/cometbft?tab=importedby

Cross references:
No existing reports found with this module or alias.

See doc/triage.md for instructions on how to triage this report.

modules:
    - module: github.com/cometbft/cometbft
      vulnerable_at: 0.37.2
      packages:
        - package: cometbft
description: |-
    CometBFT is a Byzantine Fault Tolerant (BFT) middleware that takes a state
    transition machine and replicates it on many machines. The mempool maintains two
    data structures to keep track of outstanding transactions: a list and a map.
    These two data structures are supposed to be in sync all the time in the sense
    that the map tracks the index (if any) of the transaction in the list. In
    `v0.37.0`, and `v0.37.1`, as well as in `v0.34.28`, and all previous releases of
    the CometBFT repo2, it is possible to have them out of sync. When this happens,
    the list may contain several copies of the same transaction. Because the map
    tracks a single index, it is then no longer possible to remove all the copies of
    the transaction from the list. This happens even if the duplicated transaction
    is later committed in a block. The only way to remove the transaction is by
    restarting the node.

    The above problem can be repeated on and on until a sizable number of
    transactions are stuck in the mempool, in order to try to bring down the target
    node. The problem is fixed in releases `v0.34.29` and `v0.37.2`. Some
    workarounds are available. Increasing the value of `cache_size` in `config.toml`
    makes it very difficult to effectively attack a full node. Not exposing the
    transaction submission RPC's would mitigate the probability of a successful
    attack, as the attacker would then have to create a modified (byzantine) full
    node to be able to perform the attack via p2p.
cves:
    - CVE-2023-34451
references:
    - advisory: https://github.com/cometbft/cometbft/security/advisories/GHSA-w24w-wp77-qffm
    - fix: https://github.com/cometbft/cometbft/pull/890
    - fix: https://github.com/tendermint/tendermint/pull/2778

[gopherbot]

Change https://go.dev/cl/508455 mentions this issue: data/reports: add GO-2023-1883.yaml

[gopherbot]

Change https://go.dev/cl/508457 mentions this issue: data/reports: add GO-2023-1883.yaml