build(deps): bump github.com/catenacyber/perfsprint from 0.2.0 to 0.3…

….0 (#4157)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

.golangci.reference.yml

@@ -1378,6 +1378,11 @@ linters-settings:
     # Default: false
     ignore-missing-subtests: true
 
+  perfsprint:
+    # Optimizes even if it requires an int or uint type cast.
+    # Default: true
+    int-conversion: false
+
   prealloc:
     # IMPORTANT: we don't recommend using this linter before doing performance profiling.
     # For most programs usage of prealloc will be a premature optimization.

go.mod

@@ -27,7 +27,7 @@ require (
 	github.com/breml/errchkjson v0.3.6
 	github.com/butuzov/ireturn v0.2.2
 	github.com/butuzov/mirror v1.1.0
-	github.com/catenacyber/perfsprint v0.2.0
+	github.com/catenacyber/perfsprint v0.3.0
 	github.com/charithe/durationcheck v0.0.10
 	github.com/curioswitch/go-reassign v0.2.0
 	github.com/daixiang0/gci v0.11.2

pkg/config/linters_settings.go

@@ -104,6 +104,9 @@ var defaultLintersSettings = LintersSettings{
 		RequireSpecific:    false,
 		AllowUnused:        false,
 	},
+	PerfSprint: PerfSprintSettings{
+		IntConversion: true,
+	},
 	Prealloc: PreallocSettings{
 		Simple:     true,
 		RangeLoops: true,
@@ -222,6 +225,7 @@ type LintersSettings struct {
 	NoLintLint       NoLintLintSettings
 	NoNamedReturns   NoNamedReturnsSettings
 	ParallelTest     ParallelTestSettings
+	PerfSprint       PerfSprintSettings
 	Prealloc         PreallocSettings
 	Predeclared      PredeclaredSettings
 	Promlinter       PromlinterSettings
@@ -675,11 +679,16 @@ type NoLintLintSettings struct {
 type NoNamedReturnsSettings struct {
 	ReportErrorInDefer bool `mapstructure:"report-error-in-defer"`
 }
+
 type ParallelTestSettings struct {
 	IgnoreMissing         bool `mapstructure:"ignore-missing"`
 	IgnoreMissingSubtests bool `mapstructure:"ignore-missing-subtests"`
 }
 
+type PerfSprintSettings struct {
+	IntConversion bool `mapstructure:"int-conversion"`
+}
+
 type PreallocSettings struct {
 	Simple     bool
 	RangeLoops bool `mapstructure:"range-loops"`

pkg/golinters/perfsprint.go

@@ -4,16 +4,26 @@ import (
 	"github.com/catenacyber/perfsprint/analyzer"
 	"golang.org/x/tools/go/analysis"
 
+	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )
 
-func NewPerfSprint() *goanalysis.Linter {
-	a := analyzer.Analyzer
+func NewPerfSprint(settings *config.PerfSprintSettings) *goanalysis.Linter {
+	a := analyzer.New()
+
+	var cfg map[string]map[string]any
+	if settings != nil {
+		cfg = map[string]map[string]any{
+			a.Name: {
+				"int-conversion": settings.IntConversion,
+			},
+		}
+	}
 
 	return goanalysis.NewLinter(
 		a.Name,
 		a.Doc,
 		[]*analysis.Analyzer{a},
-		nil,
+		cfg,
 	).WithLoadMode(goanalysis.LoadModeTypesInfo)
 }

pkg/lint/lintersdb/manager.go

@@ -121,6 +121,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		noLintLintCfg       *config.NoLintLintSettings
 		noNamedReturnsCfg   *config.NoNamedReturnsSettings
 		parallelTestCfg     *config.ParallelTestSettings
+		perfSprintCfg       *config.PerfSprintSettings
 		preallocCfg         *config.PreallocSettings
 		predeclaredCfg      *config.PredeclaredSettings
 		promlinterCfg       *config.PromlinterSettings
@@ -202,8 +203,9 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		nlreturnCfg = &m.cfg.LintersSettings.Nlreturn
 		noLintLintCfg = &m.cfg.LintersSettings.NoLintLint
 		noNamedReturnsCfg = &m.cfg.LintersSettings.NoNamedReturns
-		preallocCfg = &m.cfg.LintersSettings.Prealloc
 		parallelTestCfg = &m.cfg.LintersSettings.ParallelTest
+		perfSprintCfg = &m.cfg.LintersSettings.PerfSprint
+		preallocCfg = &m.cfg.LintersSettings.Prealloc
 		predeclaredCfg = &m.cfg.LintersSettings.Predeclared
 		promlinterCfg = &m.cfg.LintersSettings.Promlinter
 		reassignCfg = &m.cfg.LintersSettings.Reassign
@@ -712,7 +714,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle, linter.PresetTest).
 			WithURL("https://github.com/kunwardeep/paralleltest"),
 
-		linter.NewConfig(golinters.NewPerfSprint()).
+		linter.NewConfig(golinters.NewPerfSprint(perfSprintCfg)).
 			WithSince("v1.55.0").
 			WithLoadForGoAnalysis().
 			WithPresets(linter.PresetPerformance).

test/testdata/configs/perfsprint_int_conversion.yml

@@ -0,0 +1,3 @@
+linters-settings:
+  perfsprint:
+    int-conversion: false

test/testdata/perfsprint.go

@@ -1,7 +1,9 @@
 //golangcitest:args -Eperfsprint
 package testdata
 
-import "fmt"
+import (
+	"fmt"
+)
 
 func TestPerfsprint() {
 	var (
@@ -26,6 +28,8 @@ func TestPerfsprint() {
 	fmt.Sprintf("%d", ui)          // want "fmt.Sprintf can be replaced with faster strconv.FormatUint"
 	fmt.Sprint(ui)                 // want "fmt.Sprint can be replaced with faster strconv.FormatUint"
 	fmt.Sprintf("%x", []byte{'a'}) // want "fmt.Sprintf can be replaced with faster hex.EncodeToString"
+	fmt.Errorf("hello")            // want "fmt.Errorf can be replaced with errors.New"
+	fmt.Sprintf("Hello %s", s)     // want "fmt.Sprintf can be replaced with string addition"
 
 	fmt.Sprint("test", 42)
 	fmt.Sprint(42, 42)

test/testdata/perfsprint_int_conversion.go

@@ -0,0 +1,54 @@
+//golangcitest:args -Eperfsprint
+//golangcitest:config_path testdata/configs/perfsprint_int_conversion.yml
+package testdata
+
+import (
+	"fmt"
+)
+
+func TestPerfsprint2() {
+	var (
+		s   string
+		err error
+		b   bool
+		i   int
+		i64 int64
+		ui  uint
+	)
+
+	fmt.Sprintf("%s", s)   // want "fmt.Sprintf can be replaced with just using the string"
+	fmt.Sprint(s)          // want "fmt.Sprint can be replaced with just using the string"
+	fmt.Sprintf("%s", err) // want "fmt.Sprintf can be replaced with err.Error()"
+	fmt.Sprint(err)        // want "fmt.Sprint can be replaced with err.Error()"
+	fmt.Sprintf("%t", b)   // want "fmt.Sprintf can be replaced with faster strconv.FormatBool"
+	fmt.Sprint(b)          // want "fmt.Sprint can be replaced with faster strconv.FormatBool"
+	fmt.Sprintf("%d", i)   // want "fmt.Sprintf can be replaced with faster strconv.Itoa"
+	fmt.Sprint(i)          // want "fmt.Sprint can be replaced with faster strconv.Itoa"
+	fmt.Sprintf("%d", i64) // want "fmt.Sprintf can be replaced with faster strconv.FormatInt"
+	fmt.Sprint(i64)        // want "fmt.Sprint can be replaced with faster strconv.FormatInt"
+	fmt.Sprintf("%d", ui)
+	fmt.Sprint(ui)
+	fmt.Sprintf("%x", []byte{'a'}) // want "fmt.Sprintf can be replaced with faster hex.EncodeToString"
+	fmt.Errorf("hello")            // want "fmt.Errorf can be replaced with errors.New"
+	fmt.Sprintf("Hello %s", s)     // want "fmt.Sprintf can be replaced with string addition"
+
+	fmt.Sprint("test", 42)
+	fmt.Sprint(42, 42)
+	fmt.Sprintf("test")
+	fmt.Sprintf("%v")
+	fmt.Sprintf("%d")
+	fmt.Sprintf("%d", 42, 42)
+	fmt.Sprintf("%#d", 42)
+	fmt.Sprintf("value %d", 42)
+	fmt.Sprintf("val%d", 42)
+	fmt.Sprintf("%s %v", "hello", "world")
+	fmt.Sprintf("%#v", 42)
+	fmt.Sprintf("%T", struct{ string }{})
+	fmt.Sprintf("%%v", 42)
+	fmt.Sprintf("%3d", 42)
+	fmt.Sprintf("% d", 42)
+	fmt.Sprintf("%-10d", 42)
+	fmt.Sprintf("%[2]d %[1]d\n", 11, 22)
+	fmt.Sprintf("%[3]*.[2]*[1]f", 12.0, 2, 6)
+	fmt.Sprintf("%d %d %#[1]x %#x", 16, 17)
+}