fix regression: update thelper to v0.2.1 (#1639)

golangci · Jan 9, 2021 · 44bf197 · 44bf197
1 parent e5a395b
commit 44bf197
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/go.mod b/go.mod
@@ -31,7 +31,7 @@ require (
 	github.com/jgautheron/goconst v0.0.0-20201117150253-ccae5bf973f3
 	github.com/jingyugao/rowserrcheck v0.0.0-20191204022205-72ab7603b68a
 	github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3
-	github.com/kulti/thelper v0.2.0
+	github.com/kulti/thelper v0.2.1
 	github.com/kunwardeep/paralleltest v1.0.2
 	github.com/kyoh86/exportloopref v0.1.8
 	github.com/maratori/testpackage v1.0.1

diff --git a/go.sum b/go.sum
diff --git a/test/testdata/thelper.go b/test/testdata/thelper.go
@@ -28,3 +28,22 @@ func bhelperWithNotFirst(s string, b *testing.B, i int) { // ERROR "parameter \*
 func bhelperWithIncorrectName(o *testing.B) { // ERROR "parameter \*testing.B should have name b"
 	o.Helper()
 }
+
+func TestSubtestShouldNotBeChecked(t *testing.T) {
+	testCases := []struct {
+		desc string
+	}{
+		{
+			desc: "example",
+		},
+	}
+
+	for _, test := range testCases {
+		test := test
+		t.Run(test.desc, func(t *testing.T) {
+			t.Parallel()
+
+			t.Error("test")
+		})
+	}
+}