fix goerr13 dependencies (#1089)

golangci · May 13, 2020 · 6b124f1 · 6b124f1
1 parent 1ccecec
commit 6b124f1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -255,6 +255,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/tommy-muehle/go-mnd"),
 		linter.NewConfig(golinters.NewGoerr113()).
 			WithPresets(linter.PresetStyle).
+			WithLoadForGoAnalysis().
 			WithURL("https://github.com/Djarvur/go-err113"),
 		linter.NewConfig(golinters.NewGomodguard()).
 			WithPresets(linter.PresetStyle).

diff --git a/test/testdata/goerr113.go b/test/testdata/goerr113.go
@@ -1,10 +1,21 @@
 //args: -Egoerr113
 package testdata
 
+import "os"
+
 func SimpleEqual(e1, e2 error) bool {
 	return e1 == e2 // ERROR `err113: do not compare errors directly, use errors.Is() instead: "e1 == e2"`
 }
 
 func SimpleNotEqual(e1, e2 error) bool {
 	return e1 != e2 // ERROR `err113: do not compare errors directly, use errors.Is() instead: "e1 != e2"`
 }
+
+func CheckGoerr13Import(e error) bool {
+	f, err := os.Create("f.txt")
+	if err != nil {
+		return err == e  // ERROR `err113: do not compare errors directly, use errors.Is() instead: "err == e"`
+	}
+	f.Close()
+	return false
+}